Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ ✨ Make helm chart values extensible per component #638

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

⚠️ ✨ Make helm chart values extensible per component #638

wants to merge 5 commits into from

Conversation

rbjorklin
Copy link

@rbjorklin rbjorklin commented Nov 25, 2024 •
edited
Loading

What this PR does / why we need it:
When deploying clusters to AKS using Workload Identity an annotation is required on the service account and a label is required on the pod. By extending the chart to expose the already existing functionality to patch provider manifests this PR allows for setting up AKS clusters using Workload Identity.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @rbjorklin!

It looks like this is your first PR to kubernetes-sigs/cluster-api-operator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-operator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @rbjorklin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!

Name Link
🔨 Latest commit d22f12b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-operator/deploys/67ad22c9d6b05a00084bd422
😎 Deploy Preview https://deploy-preview-638--kubernetes-sigs-cluster-api-operator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@furkatgofurov7
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2025
@furkatgofurov7
Copy link
Member

@rbjorklin hey, would you be able to look into failing CI tests and fix them, so that we can start reviewing it ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2025
@rbjorklin
fix: add comments to large scope if & for loops
a1e8680 
The intention is to reduce time to comprehension of the chart.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danil-grigorev for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2025
@rbjorklin rbjorklin force-pushed the revamp-chart branch 2 times, most recently from 6d5c42b to 1691bc3 Compare February 12, 2025 20:02
@rbjorklin
feat: restructure chart values to allow for extending mappings
867d294 
This commit breaks the colon separated string into multiple key-value
pairs. This is in preparation for extension points to the chart.

BREAKING CHANGE: This changes the format of the values.yaml file.
Chart uses must make adaptations.
@rbjorklin
feat: extend template to support mapping 'manifestPatches' in values.…
c0af370 
…yaml
@rbjorklin
feat: extend template to support mapping 'additionalManifests' in val…
53ee5aa 
…ues.yaml
@rbjorklin
fix: align test value declaration with chart changes
d22f12b
@rbjorklin
Copy link
Author

@rbjorklin hey, would you be able to look into failing CI tests and fix them, so that we can start reviewing it ?

Fixed, please take a look!

rbjorklin
rbjorklin commented Feb 18, 2025
View reviewed changes
hack/charts/cluster-api-operator/values.yaml
Comment on lines +4 to +7
core: {}
# name: ""
# namespace: "" # Optional
# version: "" # Optional
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently not a list because:

Note: Only one CoreProvider can be installed at the same time on a single cluster.

But maybe it should be a singleton list just to align it with the others?

@rbjorklin
Copy link
Author

@furkatgofurov7 given that this changes the structure of values.yaml should I introduce a values.schema.json to make consumers of the chart aware of the change when they try rendering it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo Awaiting requested review from damdo

@Danil-Grigorev Danil-Grigorev Awaiting requested review from Danil-Grigorev

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rbjorklin @k8s-ci-robot @furkatgofurov7