🌱 Add alias to GenericProviderReconciler type #725
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @dmvolod. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-cluster-api-operator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dmvolod
force-pushed
the
export-controller-type
branch
from
7047cc5 to
e6d708e
Compare
| @@ -38,9 +38,6 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| configMapVersionLabel = "provider.cluster.x-k8s.io/version" | |||
There was a problem hiding this comment.
what is the benefit of moving these to API package? AFAICT, they are used in internal package only
There was a problem hiding this comment.
Yes, this is good question, but according to test data below, it seems to possible to have any ConfigMap name with following labels to be configured in air-gap mode, to avoid assigning name equals to provider version.
This would be an option for configuration. Seems to need to add this option to documentation.
What do you think about it?
cluster-api-operator/test/e2e/resources/core-cluster-api-v1.7.7.yaml
Lines 13358 to 13360 in 6b72fcd
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
can you run |
dmvolod
force-pushed
the
export-controller-type
branch
from
e6d708e to
b3cf2a0
Compare
Yes, sure, @furkatgofurov7 |
Not sure I am following, but changes look good to me /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This fix allows to import GenericProviderReconciler and embed it into the third-party golang code for testing and utilizing standalone without fork.
Also moves some useful labels to the API and make it public.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes issue in #727