Feature capkk controller #1129
dbbDylanAnnotations
6 errors and 3 warnings
|
lint:
pkg/controllers/kkcluster_controller.go#L252
cognitive complexity 52 of func `(*KKClusterReconciler).reconcileNormalRunning` is high (> 30) (gocognit)
|
|
lint:
pkg/controllers/kkcluster_controller.go#L681
empty-block: this block is empty, you can remove it (revive)
|
|
lint:
pkg/controllers/kkcluster_controller.go#L324
(*KKClusterReconciler).reconcileDelete - result 0 (sigs.k8s.io/controller-runtime/pkg/reconcile.Result) is always nil (unparam)
|
|
lint:
pkg/controllers/kkcluster_controller.go#L201
missing cases in switch of type v1beta1.KKClusterPhase: v1beta1.KKClusterPhaseDeleting (exhaustive)
|
|
lint:
pkg/controllers/kkcluster_controller.go#L263
missing cases in switch of type v1beta1.ConditionType: v1beta1.ReadyCondition, v1beta1.InfrastructureReadyCondition, v1beta1.ClusterClassVariablesReconciledCondition, v1beta1.ControlPlaneInitializedCondition, v1beta1.ControlPlaneReadyCondition, v1beta1.BootstrapReadyCondition, v1beta1.DrainingSucceededCondition, v1beta1.PreDrainDeleteHookSucceededCondition, v1beta1.PreTerminateDeleteHookSucceededCondition, v1beta1.VolumeDetachSucceededCondition, v1beta1.MachineHealthCheckSucceededCondition, v1beta1.MachineOwnerRemediatedCondition, v1beta1.ExternalRemediationTemplateAvailableCondition, v1beta1.ExternalRemediationRequestAvailableCondition, v1beta1.MachineNodeHealthyCondition, v1beta1.RemediationAllowedCondition, v1beta1.MachineDeploymentAvailableCondition, v1beta1.MachineSetReadyCondition, v1beta1.MachinesCreatedCondition, v1beta1.MachinesReadyCondition, v1beta1.ResizedCondition, v1beta1.TopologyReconciledCondition, v1beta1.ClusterClassRefVersionsUpToDateCondition (exhaustive)
|
|
lint
issues found
|
|
verify
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
test
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|