Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify execute command way, fix bug and optimize execution logic for playbook #2414

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

dbbDylan
Copy link

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix some bugs:

  • Modify command execute way, which is more stable for most conditions.
  • Fixed an issue where the vars_files parameter would not take effect due to the way the value was passed in the dealVarsFiles function.
  • Ignore errors when executing chrown command.

Does this PR introduced a user-facing change?

- Modify command execute way, which is more stable for most conditions.
- Fixed an issue where the `vars_files` parameter would not take effect due to the way the value was passed in the `dealVarsFiles` function.
- Ignore errors when executing `chrown` command.

@kubesphere-prow kubesphere-prow bot added release-note kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 24, 2024
Copy link

@redscholar redscholar added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 25, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dbbDylan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit fc6c8b5 into kubesphere:feature-gitops Sep 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants