Fix "Invalid number" error in set /a #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed "Invalid number. Numeric constants are either decimal (17), hexadecimal (0x11), or octal (021)." error that occurs when the two-digit hour or minute is parsed as an octal number with invalid digits (08 or 09). This is corrected by concatenating a leading "1" digit onto the two-digit hours or minutes, making them parse as 3-digit decimal number (108 or 109), and then subtracting 100 from this to yield the correct 1- or 2-digit number (8 or 9). E.g. 05 => 105 - 100 = 5 (illustrates that other 1-digit values are not affected) 08 => 108 - 100 = 8 (this would produce an error without correction, as 08 is an invalid octal number) 59 => 159 - 100 = 59 (illustrates that other 2-digit values are not affected)
Passes all command-line arguments that were supplied to the batch file into movdump.exe in addition to passing the key argument. This allows it to be run directly from the command line without hand-editing the batch file each time to add in those parameters before running it. E.g. if you need to call: movdump.exe -key KEY -atomdump -i "input_file" -o "output_file" -save 100 -entropy 65536 -start 0 -stop 100 -nfd -ref "ref_file" You would simply change "movdump.exe" to "keygen.bat", and omit the "-key" parameter, as it will be calculated: keygen.bat -atomdump -i "input_file" -o "output_file" -save 100 -entropy 65536 -start 0 -stop 100 -nfd -ref "ref_file"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed "Invalid number. Numeric constants are either decimal (17), hexadecimal (0x11), or octal (021)." error that occurs when the two-digit hour or minute is parsed as an octal number with invalid digits (08 or 09). This is corrected by concatenating a leading "1" digit onto the two-digit hours or minutes, making them parse as 3-digit decimal number (108 or 109), and then subtracting 100 from this to yield the correct 1- or 2-digit number (8 or 9).
E.g.
05 => 105 - 100 = 5 (illustrates that other 1-digit values are not affected)
08 => 108 - 100 = 8 (this would produce an error without correction, as 08 is an invalid octal number)
59 => 159 - 100 = 59 (illustrates that other 2-digit values are not affected)