Skip to content

Commit

Permalink
fix(windowparameter): Rename glazingparameter to windowparameter
Browse files Browse the repository at this point in the history
We want to be clear in our vocabulary now that we use the term Aperture" and no longer use the term "Glazing". We will, however, use the term "Window" to refer to Apertures (usually in Walls) that aren't anything special like a light tube, daylight dome, etc. Another way to phrase this is as those apertures using EnergyPlus Window Constructions and.or Radiance glass materials.
  • Loading branch information
chriswmackey authored and Chris Mackey committed Nov 12, 2019
1 parent 539dd30 commit 56e8c62
Show file tree
Hide file tree
Showing 9 changed files with 267 additions and 266 deletions.
6 changes: 3 additions & 3 deletions dragonfly/building.py
Original file line number Diff line number Diff line change
Expand Up @@ -377,10 +377,10 @@ def separate_top_bottom_floors(self):
self._unique_stories = tuple(new_ground_floors) + self._unique_stories + \
tuple(new_top_floors)

def set_outdoor_glazing_parameters(self, glazing_parameter):
"""Set all of the outdoor walls to have the same glazing parameters."""
def set_outdoor_window_parameters(self, window_parameter):
"""Set all of the outdoor walls to have the same window parameters."""
for story in self._unique_stories:
story.set_outdoor_glazing_parameters(glazing_parameter)
story.set_outdoor_window_parameters(window_parameter)

def set_outdoor_shading_parameters(self, shading_parameter):
"""Set all of the outdoor walls to have the same shading parameters."""
Expand Down
119 changes: 60 additions & 59 deletions dragonfly/room2d.py

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dragonfly/shadingparameter.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ def __init__(self):
pass

def add_shading_to_face(self, face):
"""Add Shades to a Honeybee Face using these Glazing Parameters."""
"""Add Shades to a Honeybee Face using these Window Parameters."""
pass

@classmethod
Expand Down
8 changes: 4 additions & 4 deletions dragonfly/story.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ def intersect_room_2d_adjacency(self, tolerance):
"""Automatically intersect the line segments of the Story's Room2Ds.
Note that this method effectively erases all assigned boundary conditions,
glazing parameters and shading parameters as the original segments are
window parameters and shading parameters as the original segments are
subdivided. As such, it is recommended that this method be used before all
other steps when creating a Story.
Expand All @@ -313,10 +313,10 @@ def intersect_room_2d_adjacency(self, tolerance):
"""
self._room_2ds = Room2D.intersect_adjacency(self._room_2ds, tolerance)

def set_outdoor_glazing_parameters(self, glazing_parameter):
"""Set all of the outdoor walls to have the same glazing parameters."""
def set_outdoor_window_parameters(self, window_parameter):
"""Set all of the outdoor walls to have the same window parameters."""
for room in self._room_2ds:
room.set_outdoor_glazing_parameters(glazing_parameter)
room.set_outdoor_window_parameters(window_parameter)

def set_outdoor_shading_parameters(self, shading_parameter):
"""Set all of the outdoor walls to have the same shading parameters."""
Expand Down
Loading

0 comments on commit 56e8c62

Please sign in to comment.