Add Sint32 & Sint64 types & libfuncs (#383)

* Push progress * Parse Sint8 result value * Improve sub test + fix how signed values are compared against vm values * Clippy * Improve testing * Fix * Try stuff * Fix typos * Fix test values * Add test & fix wide_mul * First draft of diff libfunc * Improve test * Remove old code * Add test * Add Sint16 type + libfuncs * fmt * Push progress * Remove uneeded intermidiate variables * Update code * Update code * Add tests for i64 libfuncs * Adjust test values * Fix cairo programs * fmt * Remove old file * Fix comment * Fix comments * Update code
lambdaclass · Dec 15, 2023 · 3c6d762 · 3c6d762
1 parent 3f6f705
commit 3c6d762
Show file tree

Hide file tree

Showing 31 changed files with 2,225 additions and 190 deletions.
diff --git a/src/jit_runner.rs b/src/jit_runner.rs
@@ -226,9 +226,39 @@ pub fn execute(
 
                 params_ptrs.push(next.to_jit(&arena, registry, param_type_id)?);
             }
-            CoreTypeConcrete::Sint32(_) => todo!(),
-            CoreTypeConcrete::Sint64(_) => todo!(),
-            CoreTypeConcrete::Sint128(_) => todo!(),
+            CoreTypeConcrete::Sint32(_) => {
+                let next = params_it
+                    .next()
+                    .ok_or_else(|| make_missing_parameter(param_type_id))?;
+
+                if !matches!(next, JITValue::Sint32(_)) {
+                    Err(make_unexpected_value_error("JITValue::Sint32".to_string()))?;
+                }
+
+                params_ptrs.push(next.to_jit(&arena, registry, param_type_id)?);
+            }
+            CoreTypeConcrete::Sint64(_) => {
+                let next = params_it
+                    .next()
+                    .ok_or_else(|| make_missing_parameter(param_type_id))?;
+
+                if !matches!(next, JITValue::Sint64(_)) {
+                    Err(make_unexpected_value_error("JITValue::Sint64".to_string()))?;
+                }
+
+                params_ptrs.push(next.to_jit(&arena, registry, param_type_id)?);
+            }
+            CoreTypeConcrete::Sint128(_) => {
+                let next = params_it
+                    .next()
+                    .ok_or_else(|| make_missing_parameter(param_type_id))?;
+
+                if !matches!(next, JITValue::Sint128(_)) {
+                    Err(make_unexpected_value_error("JITValue::Sint128".to_string()))?;
+                }
+
+                params_ptrs.push(next.to_jit(&arena, registry, param_type_id)?);
+            }
             CoreTypeConcrete::NonZero(info) => {
                 let next = params_it
                     .next()

diff --git a/src/libfuncs.rs b/src/libfuncs.rs
@@ -42,6 +42,8 @@ pub mod nullable;
 pub mod pedersen;
 pub mod poseidon;
 pub mod sint16;
+pub mod sint32;
+pub mod sint64;
 pub mod sint8;
 pub mod snapshot_take;
 pub mod stark_net;
@@ -207,8 +209,12 @@ where
             CoreConcreteLibfunc::Sint16(info) => {
                 self::sint16::build(context, registry, entry, location, helper, metadata, info)
             }
-            CoreConcreteLibfunc::Sint32(_) => todo!(),
-            CoreConcreteLibfunc::Sint64(_) => todo!(),
+            CoreConcreteLibfunc::Sint32(info) => {
+                self::sint32::build(context, registry, entry, location, helper, metadata, info)
+            }
+            CoreConcreteLibfunc::Sint64(info) => {
+                self::sint64::build(context, registry, entry, location, helper, metadata, info)
+            }
             CoreConcreteLibfunc::Sint128(_) => todo!(),
             CoreConcreteLibfunc::Bytes31(_) => todo!(),
         }

diff --git a/src/libfuncs/sint16.rs b/src/libfuncs/sint16.rs
@@ -547,11 +547,11 @@ mod test {
     fn i16_const_min() {
         let program = load_cairo!(
             fn run_test() -> i16 {
-                0_i16
+                -32768_i16
             }
         );
 
-        run_program_assert_output(&program, "run_test", &[], &[0i16.into()]);
+        run_program_assert_output(&program, "run_test", &[], &[i16::MIN.into()]);
     }
 
     #[test]