Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lockfile support for the AotContractExecutor. #1075

Merged
merged 10 commits into from
Feb 4, 2025

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@azteca1998 azteca1998 marked this pull request as ready for review January 30, 2025 17:04
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 89.20863% with 15 lines in your changes missing coverage. Please review.

Project coverage is 80.93%. Comparing base (9fae227) to head (16ce208).

Files with missing lines Patch % Lines
src/executor/contract.rs 88.46% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
+ Coverage   80.84%   80.93%   +0.08%     
==========================================
  Files         108      108              
  Lines       29581    29605      +24     
==========================================
+ Hits        23916    23961      +45     
+ Misses       5665     5644      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 30, 2025

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 4.453 ± 0.049 4.364 4.510 1.03 ± 0.02
base dict_insert.cairo (AOT) 4.336 ± 0.048 4.244 4.398 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 3.953 ± 0.051 3.879 4.040 1.00 ± 0.02
head dict_insert.cairo (AOT) 3.937 ± 0.045 3.875 4.012 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 4.188 ± 0.061 4.118 4.300 1.03 ± 0.02
base dict_snapshot.cairo (AOT) 4.078 ± 0.050 3.998 4.166 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 3.950 ± 0.064 3.835 4.029 1.03 ± 0.02
head dict_snapshot.cairo (AOT) 3.824 ± 0.035 3.778 3.881 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.576 ± 0.047 4.512 4.634 1.02 ± 0.02
base factorial_2M.cairo (AOT) 4.505 ± 0.055 4.434 4.596 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 4.260 ± 0.034 4.197 4.321 1.02 ± 0.01
head factorial_2M.cairo (AOT) 4.189 ± 0.040 4.126 4.271 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 4.103 ± 0.073 3.989 4.191 1.01 ± 0.02
base fib_2M.cairo (AOT) 4.063 ± 0.031 4.014 4.112 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 3.811 ± 0.026 3.769 3.847 1.01 ± 0.01
head fib_2M.cairo (AOT) 3.781 ± 0.029 3.743 3.841 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 4.318 ± 0.040 4.254 4.372 1.04 ± 0.01
base linear_search.cairo (AOT) 4.150 ± 0.043 4.077 4.227 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 3.892 ± 0.047 3.831 3.967 1.03 ± 0.02
head linear_search.cairo (AOT) 3.778 ± 0.038 3.699 3.830 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 4.384 ± 0.059 4.305 4.474 1.04 ± 0.02
base logistic_map.cairo (AOT) 4.223 ± 0.052 4.146 4.295 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.957 ± 0.029 3.915 4.013 1.04 ± 0.01
head logistic_map.cairo (AOT) 3.799 ± 0.022 3.769 3.843 1.00

Copy link

github-actions bot commented Jan 30, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 21.153 ± 0.260 20.875 21.652 5.75 ± 0.08
cairo-native (embedded AOT) 3.680 ± 0.019 3.646 3.712 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.820 ± 0.051 3.742 3.878 1.04 ± 0.01

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.832 ± 0.043 5.790 5.935 1.60 ± 0.02
cairo-native (embedded AOT) 3.655 ± 0.046 3.597 3.713 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.786 ± 0.051 3.719 3.888 1.04 ± 0.02

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.356 ± 0.094 14.220 14.505 3.57 ± 0.04
cairo-native (embedded AOT) 4.092 ± 0.053 3.992 4.160 1.02 ± 0.02
cairo-native (embedded JIT using LLVM's ORC Engine) 4.020 ± 0.039 3.977 4.088 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.590 ± 0.073 14.490 14.740 4.09 ± 0.04
cairo-native (embedded AOT) 3.571 ± 0.029 3.533 3.630 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.621 ± 0.040 3.570 3.698 1.01 ± 0.01

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 6.125 ± 0.051 6.052 6.195 1.63 ± 0.02
cairo-native (embedded AOT) 3.756 ± 0.033 3.704 3.819 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.846 ± 0.037 3.810 3.942 1.02 ± 0.01

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.658 ± 0.040 5.606 5.750 1.55 ± 0.01
cairo-native (embedded AOT) 3.641 ± 0.012 3.626 3.667 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.870 ± 0.019 3.850 3.916 1.06 ± 0.01

Copy link

github-actions bot commented Feb 3, 2025

✅ Code is now correctly formatted.

edg-l
edg-l previously approved these changes Feb 4, 2025
JulianGCalderon
JulianGCalderon previously approved these changes Feb 4, 2025
igaray
igaray previously approved these changes Feb 4, 2025
@edg-l edg-l dismissed stale reviews from igaray, JulianGCalderon, and themself via 16ce208 February 4, 2025 14:15
@edg-l edg-l enabled auto-merge February 4, 2025 14:29
@edg-l edg-l added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 066cda5 Feb 4, 2025
28 checks passed
@edg-l edg-l deleted the add-contract-cache-lockfile branch February 4, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants