Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove runtime crate, bump version, fix gh release ci #1085

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Conversation

edg-l
Copy link
Member

@edg-l edg-l commented Feb 4, 2025

This pr does the following:

  • Removes the runtime crate completly and cleans ups any references to it on scripts, etc.
  • Bumps the version to 0.3.0 (to be able to push a tag for release later when wanted)
  • Fix the github ci release.
  • Updates rust to 1.84.1

Fixes #1026

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

Removes the runtime crate completly and cleans ups any references to it on scripts, etc.
Bumps the version to 0.3.0 (to be able to push a tag for release later when wanted)
Fix the github ci release.
Updates rust to 1.84.1
Copy link

github-actions bot commented Feb 4, 2025

Benchmark results Main vs HEAD.

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_insert.cairo (JIT) 3.921 ± 0.030 3.882 3.967 1.02 ± 0.01
base dict_insert.cairo (AOT) 3.841 ± 0.016 3.819 3.872 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_insert.cairo (JIT) 3.946 ± 0.055 3.840 4.043 1.01 ± 0.02
head dict_insert.cairo (AOT) 3.893 ± 0.020 3.859 3.921 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base dict_snapshot.cairo (JIT) 3.788 ± 0.021 3.755 3.813 1.02 ± 0.01
base dict_snapshot.cairo (AOT) 3.706 ± 0.021 3.677 3.739 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head dict_snapshot.cairo (JIT) 3.838 ± 0.061 3.771 3.944 1.02 ± 0.02
head dict_snapshot.cairo (AOT) 3.751 ± 0.039 3.714 3.846 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base factorial_2M.cairo (JIT) 4.153 ± 0.034 4.086 4.196 1.01 ± 0.01
base factorial_2M.cairo (AOT) 4.105 ± 0.037 4.066 4.196 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 4.170 ± 0.048 4.092 4.239 1.00
head factorial_2M.cairo (AOT) 4.183 ± 0.020 4.148 4.212 1.00 ± 0.01

Base

Command Mean [s] Min [s] Max [s] Relative
base fib_2M.cairo (JIT) 3.711 ± 0.026 3.681 3.764 1.02 ± 0.01
base fib_2M.cairo (AOT) 3.631 ± 0.020 3.607 3.685 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 3.756 ± 0.062 3.675 3.838 1.03 ± 0.02
head fib_2M.cairo (AOT) 3.658 ± 0.032 3.621 3.711 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base linear_search.cairo (JIT) 3.899 ± 0.044 3.849 4.004 1.04 ± 0.01
base linear_search.cairo (AOT) 3.751 ± 0.011 3.731 3.768 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head linear_search.cairo (JIT) 3.913 ± 0.041 3.860 3.982 1.05 ± 0.01
head linear_search.cairo (AOT) 3.724 ± 0.034 3.675 3.762 1.00

Base

Command Mean [s] Min [s] Max [s] Relative
base logistic_map.cairo (JIT) 3.992 ± 0.031 3.949 4.051 1.05 ± 0.01
base logistic_map.cairo (AOT) 3.806 ± 0.019 3.775 3.840 1.00

Head

Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 3.990 ± 0.043 3.921 4.063 1.04 ± 0.02
head logistic_map.cairo (AOT) 3.845 ± 0.057 3.778 3.958 1.00

@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (03273cb) to head (9b88099).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1085      +/-   ##
==========================================
+ Coverage   80.80%   80.83%   +0.02%     
==========================================
  Files         108      108              
  Lines       29563    29552      -11     
==========================================
- Hits        23888    23887       -1     
+ Misses       5675     5665      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 4, 2025

Benchmarking results

Benchmark for program dict_insert

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 20.881 ± 0.310 20.699 21.748 5.54 ± 0.09
cairo-native (embedded AOT) 3.770 ± 0.024 3.742 3.817 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.855 ± 0.024 3.811 3.898 1.02 ± 0.01

Benchmark for program dict_snapshot

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.833 ± 0.030 5.775 5.900 1.60 ± 0.02
cairo-native (embedded AOT) 3.636 ± 0.031 3.592 3.705 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.741 ± 0.036 3.703 3.830 1.03 ± 0.01

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.487 ± 0.117 14.280 14.690 3.55 ± 0.04
cairo-native (embedded AOT) 4.113 ± 0.044 4.075 4.222 1.01 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 4.081 ± 0.030 4.043 4.144 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 14.343 ± 0.036 14.281 14.413 3.98 ± 0.04
cairo-native (embedded AOT) 3.607 ± 0.039 3.567 3.664 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.694 ± 0.047 3.622 3.771 1.02 ± 0.02

Benchmark for program linear_search

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.829 ± 0.036 5.770 5.890 1.58 ± 0.02
cairo-native (embedded AOT) 3.698 ± 0.029 3.650 3.745 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.818 ± 0.031 3.781 3.867 1.03 ± 0.01

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 5.902 ± 0.072 5.785 6.002 1.53 ± 0.02
cairo-native (embedded AOT) 3.847 ± 0.034 3.798 3.915 1.00
cairo-native (embedded JIT using LLVM's ORC Engine) 3.996 ± 0.017 3.970 4.028 1.04 ± 0.01

@edg-l edg-l added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 9fae227 Feb 4, 2025
28 checks passed
@edg-l edg-l deleted the cleanup_runtime branch February 4, 2025 13:43
azteca1998 pushed a commit that referenced this pull request Feb 4, 2025
* Remove runtime crate, bump version, fix gh release ci

Removes the runtime crate completly and cleans ups any references to it on scripts, etc.
Bumps the version to 0.3.0 (to be able to push a tag for release later when wanted)
Fix the github ci release.
Updates rust to 1.84.1

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet