-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove runtime crate, bump version, fix gh release ci #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edg-l
requested review from
igaray,
azteca1998,
jrchatruc,
entropidelic,
fmoletta,
Oppen,
pefontana and
gabrielbosio
as code owners
February 4, 2025 08:47
Removes the runtime crate completly and cleans ups any references to it on scripts, etc. Bumps the version to 0.3.0 (to be able to push a tag for release later when wanted) Fix the github ci release. Updates rust to 1.84.1
edg-l
force-pushed
the
cleanup_runtime
branch
from
February 4, 2025 08:50
90135b7
to
36dce16
Compare
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
==========================================
+ Coverage 80.80% 80.83% +0.02%
==========================================
Files 108 108
Lines 29563 29552 -11
==========================================
- Hits 23888 23887 -1
+ Misses 5675 5665 -10 ☔ View full report in Codecov by Sentry. |
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
20.881 ± 0.310 | 20.699 | 21.748 | 5.54 ± 0.09 |
cairo-native (embedded AOT) |
3.770 ± 0.024 | 3.742 | 3.817 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.855 ± 0.024 | 3.811 | 3.898 | 1.02 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.833 ± 0.030 | 5.775 | 5.900 | 1.60 ± 0.02 |
cairo-native (embedded AOT) |
3.636 ± 0.031 | 3.592 | 3.705 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.741 ± 0.036 | 3.703 | 3.830 | 1.03 ± 0.01 |
Benchmark for program factorial_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
14.487 ± 0.117 | 14.280 | 14.690 | 3.55 ± 0.04 |
cairo-native (embedded AOT) |
4.113 ± 0.044 | 4.075 | 4.222 | 1.01 ± 0.01 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
4.081 ± 0.030 | 4.043 | 4.144 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
14.343 ± 0.036 | 14.281 | 14.413 | 3.98 ± 0.04 |
cairo-native (embedded AOT) |
3.607 ± 0.039 | 3.567 | 3.664 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.694 ± 0.047 | 3.622 | 3.771 | 1.02 ± 0.02 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.829 ± 0.036 | 5.770 | 5.890 | 1.58 ± 0.02 |
cairo-native (embedded AOT) |
3.698 ± 0.029 | 3.650 | 3.745 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.818 ± 0.031 | 3.781 | 3.867 | 1.03 ± 0.01 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.902 ± 0.072 | 5.785 | 6.002 | 1.53 ± 0.02 |
cairo-native (embedded AOT) |
3.847 ± 0.034 | 3.798 | 3.915 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.996 ± 0.017 | 3.970 | 4.028 | 1.04 ± 0.01 |
FrancoGiachetta
approved these changes
Feb 4, 2025
azteca1998
approved these changes
Feb 4, 2025
azteca1998
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Remove runtime crate, bump version, fix gh release ci Removes the runtime crate completly and cleans ups any references to it on scripts, etc. Bumps the version to 0.3.0 (to be able to push a tag for release later when wanted) Fix the github ci release. Updates rust to 1.84.1 * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr does the following:
Fixes #1026
Checklist