Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli for sierra to native compilation in Starknet blockifier #1091

Conversation

avi-starkware
Copy link
Contributor

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (e8c7545) to head (7980d3f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1091   +/-   ##
=======================================
  Coverage   80.86%   80.86%           
=======================================
  Files         109      109           
  Lines       29790    29790           
=======================================
  Hits        24089    24089           
  Misses       5701     5701           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edg-l edg-l force-pushed the avi/add-starknet-native-compile-cli branch from 8f4ae59 to 161418d Compare February 11, 2025 14:25
@gabrielbosio
Copy link
Collaborator

gabrielbosio commented Feb 11, 2025

CI was failing with:

Unable to fetch the transaction hashes.: StateReadError("builder error: relative URL without a base")

#1094 cherry-picks the commits of this PR and makes CI to finish successfully. We think it succeeded because of the owner of #1094 has more permissions than the owner of this PR but we are not sure.

Because #1094 solves this, we can close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants