-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cross-device-link error when compiling contract #1092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd85f4b
to
4281ad2
Compare
azteca1998
approved these changes
Feb 10, 2025
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1092 +/- ##
==========================================
- Coverage 81.05% 81.04% -0.01%
==========================================
Files 108 108
Lines 29722 29723 +1
==========================================
- Hits 24091 24089 -2
- Misses 5631 5634 +3 ☔ View full report in Codecov by Sentry. |
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
20.917 ± 0.052 | 20.827 | 21.001 | 5.58 ± 0.03 |
cairo-native (embedded AOT) |
3.746 ± 0.018 | 3.720 | 3.780 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.821 ± 0.025 | 3.772 | 3.850 | 1.02 ± 0.01 |
Benchmark for program dict_snapshot
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.835 ± 0.023 | 5.795 | 5.874 | 1.61 ± 0.01 |
cairo-native (embedded AOT) |
3.626 ± 0.022 | 3.596 | 3.669 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.725 ± 0.034 | 3.680 | 3.806 | 1.03 ± 0.01 |
Benchmark for program factorial_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
14.516 ± 0.186 | 14.415 | 15.038 | 3.62 ± 0.06 |
cairo-native (embedded AOT) |
4.005 ± 0.033 | 3.969 | 4.091 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
4.046 ± 0.025 | 3.998 | 4.086 | 1.01 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
14.311 ± 0.067 | 14.179 | 14.404 | 4.02 ± 0.03 |
cairo-native (embedded AOT) |
3.556 ± 0.017 | 3.531 | 3.583 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.592 ± 0.022 | 3.572 | 3.646 | 1.01 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.838 ± 0.035 | 5.771 | 5.881 | 1.60 ± 0.01 |
cairo-native (embedded AOT) |
3.660 ± 0.023 | 3.627 | 3.688 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.789 ± 0.038 | 3.739 | 3.867 | 1.04 ± 0.01 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.740 ± 0.036 | 5.684 | 5.796 | 1.55 ± 0.01 |
cairo-native (embedded AOT) |
3.705 ± 0.021 | 3.668 | 3.734 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.889 ± 0.022 | 3.868 | 3.940 | 1.05 ± 0.01 |
edg-l
approved these changes
Feb 10, 2025
igaray
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling contracts in our server, we encountered the following error:
IoError(Os { code: 18, kind: CrossesDevices, message: "Invalid cross-device link" })
.This seems to happen when the temporary file used to compile contract is not in the same file system as the requested output path.
To fix this, instead of using a temporary file, the lockfile is used as a tmp file, and then renamed to the output path.
Checklist