Add old ubuntu 20.04 focal to ci #1097

edg-l · 2025-02-14T09:57:16Z

Checklist

Linked to Github Issue
Unit tests added
Integration tests added.
This change requires new documentation.
- Documentation has been added/updated.

github-actions · 2025-02-14T10:22:34Z

Benchmark results Main vs HEAD.

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_insert.cairo (JIT)`	3.979 ± 0.030	3.921	4.024	1.00 ± 0.02
`base dict_insert.cairo (AOT)`	3.976 ± 0.065	3.913	4.115	1.00

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head dict_insert.cairo (JIT)`	3.920 ± 0.027	3.867	3.953	1.02 ± 0.01
`head dict_insert.cairo (AOT)`	3.833 ± 0.031	3.784	3.883	1.00

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base dict_snapshot.cairo (JIT)`	3.852 ± 0.067	3.766	3.961	1.04 ± 0.02
`base dict_snapshot.cairo (AOT)`	3.700 ± 0.061	3.612	3.804	1.00

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head dict_snapshot.cairo (JIT)`	3.816 ± 0.041	3.763	3.918	1.03 ± 0.01
`head dict_snapshot.cairo (AOT)`	3.697 ± 0.024	3.672	3.755	1.00

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base factorial_2M.cairo (JIT)`	4.099 ± 0.042	4.058	4.189	1.01 ± 0.02
`base factorial_2M.cairo (AOT)`	4.065 ± 0.055	3.993	4.180	1.00

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head factorial_2M.cairo (JIT)`	4.141 ± 0.017	4.109	4.165	1.01 ± 0.01
`head factorial_2M.cairo (AOT)`	4.104 ± 0.029	4.081	4.171	1.00

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base fib_2M.cairo (JIT)`	3.633 ± 0.051	3.576	3.714	1.00
`base fib_2M.cairo (AOT)`	3.649 ± 0.059	3.552	3.743	1.00 ± 0.02

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head fib_2M.cairo (JIT)`	3.686 ± 0.015	3.663	3.714	1.00
`head fib_2M.cairo (AOT)`	3.697 ± 0.029	3.656	3.745	1.00 ± 0.01

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base linear_search.cairo (JIT)`	3.892 ± 0.060	3.813	4.012	1.04 ± 0.02
`base linear_search.cairo (AOT)`	3.738 ± 0.051	3.670	3.825	1.00

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head linear_search.cairo (JIT)`	4.025 ± 0.114	3.904	4.197	1.05 ± 0.03
`head linear_search.cairo (AOT)`	3.825 ± 0.046	3.790	3.948	1.00

Base

Command	Mean [s]	Min [s]	Max [s]	Relative
`base logistic_map.cairo (JIT)`	4.054 ± 0.093	3.904	4.168	1.05 ± 0.03
`base logistic_map.cairo (AOT)`	3.871 ± 0.046	3.779	3.908	1.00

Head

Command	Mean [s]	Min [s]	Max [s]	Relative
`head logistic_map.cairo (JIT)`	4.014 ± 0.029	3.956	4.051	1.04 ± 0.01
`head logistic_map.cairo (AOT)`	3.865 ± 0.032	3.818	3.917	1.00

codecov-commenter · 2025-02-14T10:33:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (17edff7) to head (0cd827b).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1097   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files         109      109           
  Lines       29784    29784           
=======================================
  Hits        24067    24067           
  Misses       5717     5717

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2025-02-14T10:35:57Z

Benchmarking results

Benchmark for program `dict_insert`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	20.893 ± 0.147	20.755	21.159	5.45 ± 0.07
`cairo-native (embedded AOT)`	3.834 ± 0.041	3.781	3.924	1.00
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.898 ± 0.023	3.845	3.931	1.02 ± 0.01

Benchmark for program `dict_snapshot`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	5.862 ± 0.040	5.784	5.940	1.60 ± 0.01
`cairo-native (embedded AOT)`	3.659 ± 0.022	3.630	3.702	1.00
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.776 ± 0.019	3.757	3.818	1.03 ± 0.01

Benchmark for program `factorial_2M`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	14.522 ± 0.094	14.384	14.726	3.56 ± 0.03
`cairo-native (embedded AOT)`	4.082 ± 0.020	4.038	4.105	1.00
`cairo-native (embedded JIT using LLVM's ORC Engine)`	4.113 ± 0.014	4.092	4.131	1.01 ± 0.01

Benchmark for program `fib_2M`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	14.449 ± 0.084	14.361	14.625	3.98 ± 0.04
`cairo-native (embedded AOT)`	3.627 ± 0.027	3.581	3.673	1.00
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.650 ± 0.037	3.603	3.724	1.01 ± 0.01

Benchmark for program `linear_search`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	5.983 ± 0.057	5.906	6.056	1.60 ± 0.02
`cairo-native (embedded AOT)`	3.749 ± 0.027	3.722	3.793	1.00
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.855 ± 0.015	3.838	3.876	1.03 ± 0.01

Benchmark for program `logistic_map`

Open benchmarks

Command	Mean [s]	Min [s]	Max [s]	Relative
`Cairo-vm (Rust, Cairo 1)`	5.816 ± 0.043	5.758	5.886	1.54 ± 0.01
`cairo-native (embedded AOT)`	3.765 ± 0.018	3.739	3.794	1.00
`cairo-native (embedded JIT using LLVM's ORC Engine)`	3.920 ± 0.025	3.889	3.965	1.04 ± 0.01

JulianGCalderon · 2025-02-18T15:06:06Z

.github/workflows/ci.yml

+      - name: check and free hdd space left
+        run: |
+          echo "Listing 20 largest packages"
+          dpkg-query -Wf '${Installed-Size}\t${Package}\n' | sort -n | tail -n 20
+          df -h
+          sudo apt-get update
+          sudo apt-get remove -y '^llvm-.*'
+          sudo apt-get remove -y 'php.*'
+          sudo apt-get remove -y '^dotnet-.*'
+          sudo apt-get remove -y '^temurin-.*'
+          sudo apt-get autoremove -y
+          sudo apt-get clean
+          df -h
+          echo "Removing large directories"
+          # deleting 15GB
+          sudo rm -rf /usr/share/dotnet/
+          sudo rm -rf /usr/local/lib/android
+          df -h
+      - name: Setup rust env
+        uses: dtolnay/[email protected]
+      - name: Retreive cached dependecies
+        uses: Swatinem/rust-cache@v2
+      - name: add llvm deb repository
+        uses: myci-actions/add-deb-repo@11
+        with:
+          repo: deb http://apt.llvm.org/focal/ llvm-toolchain-focal-19 main
+          repo-name: llvm-repo
+          keys-asc: https://apt.llvm.org/llvm-snapshot.gpg.key
+      - run: sudo apt-get update && sudo apt-get upgrade -y
+      - name: Install LLVM
+        run: sudo apt-get install libzstd-dev  llvm-19 llvm-19-dev llvm-19-runtime clang-19 clang-tools-19 lld-19 libpolly-19-dev libmlir-19-dev mlir-19-tools


Here you could use install-linux-deps action to make the workflow a bit smaller:

cairo_native/.github/workflows/daily.yml

Lines 100 to 107 in 17edff7

# Install dependencies

- uses: ./cairo_native/.github/actions/install-linux-deps

- name: Setup rust env

uses: dtolnay/[email protected]

- name: Retreive cached dependecies

uses: Swatinem/rust-cache@v2

with:

workspaces: starknet-replay

Add old ubuntu 20.04 focal to ci

16dee93

edg-l requested review from igaray, azteca1998, jrchatruc, entropidelic, fmoletta, Oppen, pefontana and gabrielbosio as code owners February 14, 2025 09:57

edg-l added 2 commits February 14, 2025 12:57

add zstd

46c3532

fix

c6523eb

igaray approved these changes Feb 17, 2025

View reviewed changes

Merge branch 'main' into ubuntu_old

0cd827b

JulianGCalderon reviewed Feb 18, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add old ubuntu 20.04 focal to ci #1097

Add old ubuntu 20.04 focal to ci #1097

edg-l commented Feb 14, 2025

github-actions bot commented Feb 14, 2025 •

edited

Loading

codecov-commenter commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

JulianGCalderon Feb 18, 2025

	# Install dependencies
	- uses: ./cairo_native/.github/actions/install-linux-deps
	- name: Setup rust env
	uses: dtolnay/[email protected]
	- name: Retreive cached dependecies
	uses: Swatinem/rust-cache@v2
	with:
	workspaces: starknet-replay

Add old ubuntu 20.04 focal to ci #1097

Are you sure you want to change the base?

Add old ubuntu 20.04 focal to ci #1097

Conversation

edg-l commented Feb 14, 2025

Checklist

github-actions bot commented Feb 14, 2025 • edited Loading

Benchmark results Main vs HEAD.

Base

Head

Base

Head

Base

Head

Base

Head

Base

Head

Base

Head

codecov-commenter commented Feb 14, 2025 • edited Loading

Codecov Report

github-actions bot commented Feb 14, 2025 • edited Loading

Benchmarking results

Benchmark for program dict_insert

Benchmark for program dict_snapshot

Benchmark for program factorial_2M

Benchmark for program fib_2M

Benchmark for program linear_search

Benchmark for program logistic_map

JulianGCalderon Feb 18, 2025

Choose a reason for hiding this comment

github-actions bot commented Feb 14, 2025 •

edited

Loading

codecov-commenter commented Feb 14, 2025 •

edited

Loading

github-actions bot commented Feb 14, 2025 •

edited

Loading

Benchmark for program `dict_insert`

Benchmark for program `dict_snapshot`

Benchmark for program `factorial_2M`

Benchmark for program `fib_2M`

Benchmark for program `linear_search`

Benchmark for program `logistic_map`