-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in ec_point_from_x
#386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 14, 2023
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
20.844 ± 0.133 | 20.650 | 21.025 | 42.95 ± 0.29 |
cairo-native (JIT MLIR ORC Engine) |
1.531 ± 0.011 | 1.518 | 1.555 | 3.15 ± 0.02 |
cairo-native (AOT Native binary) |
0.661 ± 0.004 | 0.658 | 0.672 | 1.36 ± 0.01 |
cairo-native (AOT Native binary with host CPU features, march=native) |
0.485 ± 0.001 | 0.484 | 0.488 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
20.378 ± 0.167 | 20.206 | 20.689 | 652.99 ± 10.41 |
cairo-native (JIT MLIR ORC Engine) |
1.114 ± 0.010 | 1.102 | 1.133 | 35.70 ± 0.58 |
cairo-native (AOT Native binary) |
0.031 ± 0.000 | 0.031 | 0.033 | 1.00 |
cairo-native (AOT Native binary with host CPU features, march=native) |
0.031 ± 0.000 | 0.031 | 0.032 | 1.00 ± 0.01 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
1.895 ± 0.022 | 1.868 | 1.924 | 27.13 ± 0.32 |
cairo-native (JIT MLIR ORC Engine) |
1.414 ± 0.011 | 1.398 | 1.428 | 20.25 ± 0.16 |
cairo-native (AOT Native binary) |
0.109 ± 0.000 | 0.109 | 0.110 | 1.56 ± 0.00 |
cairo-native (AOT Native binary with host CPU features, march=native) |
0.070 ± 0.000 | 0.070 | 0.070 | 1.00 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
=======================================
Coverage 75.89% 75.89%
=======================================
Files 100 100
Lines 23897 23901 +4
=======================================
+ Hits 18136 18140 +4
Misses 5761 5761 ☔ View full report in Codecov by Sentry. |
Thanks for fixing this bug! |
edg-l
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Libfunc
ec_point_from_x_nz
now uses -y instead of y when y > PRIME / 2Add comparison between native and vm values for
NonZero
typesTests
ec_point_from_x_proptest
,ec_point_from_x_big
&ec_point_from_x_small
now passing