[GH-1054] Bots movement improvement #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvillegas98
changed the title
manucamejo
requested changes
Jan 29, 2025
apps/bot_manager/lib/utils.ex
Outdated
| def get_distance_and_direction_to_positions(base_position, end_position) do | ||
| %{x: x, y: y} = Vector.sub(end_position, base_position) | ||
|
|
||
| distance = :math.sqrt(:math.pow(x, 2) + :math.pow(y, 2)) |
There was a problem hiding this comment.
Can you use the distance function that you just created in apps/bot_manager/lib/math/vector.ex?
There was a problem hiding this comment.
manucamejo
approved these changes
Jan 30, 2025
Nico-Sanchez
approved these changes
Feb 3, 2025
Comment on lines
+50
to
+56
| position_to_move_to: nil, | ||
| time_amount_to_change_position: 2000, | ||
| last_time_position_changed: 0, | ||
| max_vision_range_to_follow_player: 1500, | ||
| vision_range_to_attack_player: 1200, | ||
| stuck_in_position: nil, | ||
| start_time_stuck_in_position: nil |
There was a problem hiding this comment.
Let's create an issue to remove these magic numbers to make them parametrizable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The randomness of the movements led our bots walking near the externall walls, now they will move through positions around the map and also they will be able to track players
Closes #1054
Summary of changes
How to test it?
Play with the bots and leave a feedback about their behavior!
Checklist