feat(starknet_sequencer_node): creating communication clients for cla…

…ss manager and serra compiler (starkware-libs#3393)

commit-id:a12ae4a1

config/sequencer/default_config.json

@@ -339,6 +339,36 @@
     "privacy": "Public",
     "value": "0.0.0.0:0"
   },
+  "components.class_manager.execution_mode": {
+    "description": "The component execution mode.",
+    "privacy": "Public",
+    "value": "LocalExecutionWithRemoteDisabled"
+  },
+  "components.class_manager.local_server_config.channel_buffer_size": {
+    "description": "The communication channel buffer size.",
+    "privacy": "Public",
+    "value": 32
+  },
+  "components.class_manager.remote_client_config.idle_connections": {
+    "description": "The maximum number of idle connections to keep alive.",
+    "privacy": "Public",
+    "value": 18446744073709551615
+  },
+  "components.class_manager.remote_client_config.idle_timeout": {
+    "description": "The duration in seconds to keep an idle connection open before closing.",
+    "privacy": "Public",
+    "value": 90
+  },
+  "components.class_manager.remote_client_config.retries": {
+    "description": "The max number of retries for sending a message.",
+    "privacy": "Public",
+    "value": 3
+  },
+  "components.class_manager.socket": {
+    "description": "The remote component socket.",
+    "privacy": "Public",
+    "value": "0.0.0.0:0"
+  },
   "components.consensus_manager.execution_mode": {
     "description": "The component execution mode.",
     "privacy": "Public",
@@ -479,6 +509,36 @@
     "privacy": "Public",
     "value": "Enabled"
   },
+  "components.sierra_compiler.execution_mode": {
+    "description": "The component execution mode.",
+    "privacy": "Public",
+    "value": "LocalExecutionWithRemoteDisabled"
+  },
+  "components.sierra_compiler.local_server_config.channel_buffer_size": {
+    "description": "The communication channel buffer size.",
+    "privacy": "Public",
+    "value": 32
+  },
+  "components.sierra_compiler.remote_client_config.idle_connections": {
+    "description": "The maximum number of idle connections to keep alive.",
+    "privacy": "Public",
+    "value": 18446744073709551615
+  },
+  "components.sierra_compiler.remote_client_config.idle_timeout": {
+    "description": "The duration in seconds to keep an idle connection open before closing.",
+    "privacy": "Public",
+    "value": 90
+  },
+  "components.sierra_compiler.remote_client_config.retries": {
+    "description": "The max number of retries for sending a message.",
+    "privacy": "Public",
+    "value": 3
+  },
+  "components.sierra_compiler.socket": {
+    "description": "The remote component socket.",
+    "privacy": "Public",
+    "value": "0.0.0.0:0"
+  },
   "components.state_sync.execution_mode": {
     "description": "The component execution mode.",
     "privacy": "Public",

crates/starknet_class_manager_types/src/lib.rs

@@ -9,14 +9,27 @@ use starknet_api::contract_class::ContractClass;
 use starknet_api::core::{ClassHash, CompiledClassHash};
 use starknet_api::deprecated_contract_class::ContractClass as DeprecatedClass;
 use starknet_api::state::SierraContractClass;
-use starknet_sequencer_infra::component_client::ClientError;
-use starknet_sequencer_infra::component_definitions::ComponentClient;
+use starknet_sequencer_infra::component_client::{
+    ClientError,
+    LocalComponentClient,
+    RemoteComponentClient,
+};
+use starknet_sequencer_infra::component_definitions::{
+    ComponentClient,
+    ComponentRequestAndResponseSender,
+};
 use thiserror::Error;
 
 pub type ClassManagerResult<T> = Result<T, ClassManagerError>;
 pub type ClassManagerClientResult<T> = Result<T, ClassManagerClientError>;
 
+pub type LocalClassManagerClient = LocalComponentClient<ClassManagerRequest, ClassManagerResponse>;
+pub type RemoteClassManagerClient =
+    RemoteComponentClient<ClassManagerRequest, ClassManagerResponse>;
+
 pub type SharedClassManagerClient = Arc<dyn ClassManagerClient>;
+pub type ClassManagerRequestAndResponseSender =
+    ComponentRequestAndResponseSender<ClassManagerRequest, ClassManagerResponse>;
 
 // TODO: export.
 pub type ClassId = ClassHash;

crates/starknet_sequencer_node/Cargo.toml

@@ -25,6 +25,7 @@ serde_json.workspace = true
 starknet_api.workspace = true
 starknet_batcher.workspace = true
 starknet_batcher_types.workspace = true
+starknet_class_manager_types.workspace = true
 starknet_consensus_manager.workspace = true
 starknet_gateway.workspace = true
 starknet_gateway_types.workspace = true
@@ -39,6 +40,7 @@ starknet_mempool_types.workspace = true
 starknet_monitoring_endpoint.workspace = true
 starknet_sequencer_infra.workspace = true
 starknet_sierra_compile.workspace = true
+starknet_sierra_compile_types.workspace = true
 starknet_state_sync.workspace = true
 starknet_state_sync_types.workspace = true
 tokio.workspace = true

crates/starknet_sequencer_node/src/clients.rs

@@ -7,6 +7,13 @@ use starknet_batcher_types::communication::{
     RemoteBatcherClient,
     SharedBatcherClient,
 };
+use starknet_class_manager_types::{
+    ClassManagerRequest,
+    ClassManagerResponse,
+    LocalClassManagerClient,
+    RemoteClassManagerClient,
+    SharedClassManagerClient,
+};
 use starknet_gateway_types::communication::{
     GatewayRequest,
     GatewayResponse,
@@ -31,6 +38,13 @@ use starknet_mempool_types::communication::{
     SharedMempoolClient,
 };
 use starknet_sequencer_infra::component_client::{Client, LocalComponentClient};
+use starknet_sierra_compile_types::{
+    LocalSierraCompilerClient,
+    RemoteSierraCompilerClient,
+    SharedSierraCompilerClient,
+    SierraCompilerRequest,
+    SierraCompilerResponse,
+};
 use starknet_state_sync_types::communication::{
     LocalStateSyncClient,
     RemoteStateSyncClient,
@@ -45,10 +59,12 @@ use crate::config::node_config::SequencerNodeConfig;
 
 pub struct SequencerNodeClients {
     batcher_client: Client<BatcherRequest, BatcherResponse>,
+    class_manager_client: Client<ClassManagerRequest, ClassManagerResponse>,
     mempool_client: Client<MempoolRequest, MempoolResponse>,
     gateway_client: Client<GatewayRequest, GatewayResponse>,
     mempool_p2p_propagator_client:
         Client<MempoolP2pPropagatorRequest, MempoolP2pPropagatorResponse>,
+    sierra_compiler_client: Client<SierraCompilerRequest, SierraCompilerResponse>,
     state_sync_client: Client<StateSyncRequest, StateSyncResponse>,
     l1_provider_client: Client<L1ProviderRequest, L1ProviderResponse>,
 }
@@ -95,6 +111,7 @@ macro_rules! get_shared_client {
 }
 
 // TODO(Nadin): Refactor getters to remove code duplication.
+// TODO(Lev/Itay): Too many functions, need to be sorted in a meaningful way.
 impl SequencerNodeClients {
     pub fn get_batcher_shared_client(&self) -> Option<SharedBatcherClient> {
         get_shared_client!(self, batcher_client)
@@ -106,6 +123,16 @@ impl SequencerNodeClients {
         self.batcher_client.get_local_client()
     }
 
+    pub fn get_class_manager_shared_client(&self) -> Option<SharedClassManagerClient> {
+        get_shared_client!(self, class_manager_client)
+    }
+
+    pub fn get_class_manager_local_client(
+        &self,
+    ) -> Option<LocalComponentClient<ClassManagerRequest, ClassManagerResponse>> {
+        self.class_manager_client.get_local_client()
+    }
+
     pub fn get_mempool_shared_client(&self) -> Option<SharedMempoolClient> {
         get_shared_client!(self, mempool_client)
     }
@@ -149,6 +176,16 @@ impl SequencerNodeClients {
         self.mempool_p2p_propagator_client.get_local_client()
     }
 
+    pub fn get_sierra_compiler_shared_client(&self) -> Option<SharedSierraCompilerClient> {
+        get_shared_client!(self, sierra_compiler_client)
+    }
+
+    pub fn get_sierra_compiler_local_client(
+        &self,
+    ) -> Option<LocalComponentClient<SierraCompilerRequest, SierraCompilerResponse>> {
+        self.sierra_compiler_client.get_local_client()
+    }
+
     pub fn get_state_sync_shared_client(&self) -> Option<SharedStateSyncClient> {
         get_shared_client!(self, state_sync_client)
     }
@@ -226,6 +263,14 @@ pub fn create_node_clients(
         &config.components.batcher.remote_client_config,
         config.components.batcher.socket
     );
+    let class_manager_client = create_client!(
+        &config.components.class_manager.execution_mode,
+        LocalClassManagerClient,
+        RemoteClassManagerClient,
+        channels.take_class_manager_tx(),
+        &config.components.class_manager.remote_client_config,
+        config.components.class_manager.socket
+    );
     let mempool_client = create_client!(
         &config.components.mempool.execution_mode,
         LocalMempoolClient,
@@ -252,6 +297,15 @@ pub fn create_node_clients(
         config.components.mempool_p2p.socket
     );
 
+    let sierra_compiler_client = create_client!(
+        &config.components.sierra_compiler.execution_mode,
+        LocalSierraCompilerClient,
+        RemoteSierraCompilerClient,
+        channels.take_sierra_compiler_tx(),
+        &config.components.sierra_compiler.remote_client_config,
+        config.components.sierra_compiler.socket
+    );
+
     let state_sync_client = create_client!(
         &config.components.state_sync.execution_mode,
         LocalStateSyncClient,
@@ -272,9 +326,11 @@ pub fn create_node_clients(
 
     SequencerNodeClients {
         batcher_client,
+        class_manager_client,
         mempool_client,
         gateway_client,
         mempool_p2p_propagator_client,
+        sierra_compiler_client,
         state_sync_client,
         l1_provider_client,
     }

crates/starknet_sequencer_node/src/communication.rs

@@ -1,19 +1,23 @@
 use starknet_batcher_types::communication::BatcherRequestAndResponseSender;
+use starknet_class_manager_types::ClassManagerRequestAndResponseSender;
 use starknet_gateway_types::communication::GatewayRequestAndResponseSender;
 use starknet_l1_provider::communication::L1ProviderRequestAndResponseSender;
 use starknet_mempool_p2p_types::communication::MempoolP2pPropagatorRequestAndResponseSender;
 use starknet_mempool_types::communication::MempoolRequestAndResponseSender;
 use starknet_sequencer_infra::component_definitions::ComponentCommunication;
+use starknet_sierra_compile_types::SierraCompilerRequestAndResponseSender;
 use starknet_state_sync_types::communication::StateSyncRequestAndResponseSender;
 use tokio::sync::mpsc::{channel, Receiver, Sender};
 
 pub struct SequencerNodeCommunication {
     batcher_channel: ComponentCommunication<BatcherRequestAndResponseSender>,
+    class_manager_channel: ComponentCommunication<ClassManagerRequestAndResponseSender>,
     gateway_channel: ComponentCommunication<GatewayRequestAndResponseSender>,
     l1_provider_channel: ComponentCommunication<L1ProviderRequestAndResponseSender>,
     mempool_channel: ComponentCommunication<MempoolRequestAndResponseSender>,
     mempool_p2p_propagator_channel:
         ComponentCommunication<MempoolP2pPropagatorRequestAndResponseSender>,
+    sierra_compiler_channel: ComponentCommunication<SierraCompilerRequestAndResponseSender>,
     state_sync_channel: ComponentCommunication<StateSyncRequestAndResponseSender>,
 }
 
@@ -26,6 +30,14 @@ impl SequencerNodeCommunication {
         self.batcher_channel.take_rx()
     }
 
+    pub fn take_class_manager_tx(&mut self) -> Sender<ClassManagerRequestAndResponseSender> {
+        self.class_manager_channel.take_tx()
+    }
+
+    pub fn take_class_manager_rx(&mut self) -> Receiver<ClassManagerRequestAndResponseSender> {
+        self.class_manager_channel.take_rx()
+    }
+
     pub fn take_gateway_tx(&mut self) -> Sender<GatewayRequestAndResponseSender> {
         self.gateway_channel.take_tx()
     }
@@ -61,6 +73,14 @@ impl SequencerNodeCommunication {
         self.mempool_channel.take_rx()
     }
 
+    pub fn take_sierra_compiler_tx(&mut self) -> Sender<SierraCompilerRequestAndResponseSender> {
+        self.sierra_compiler_channel.take_tx()
+    }
+
+    pub fn take_sierra_compiler_rx(&mut self) -> Receiver<SierraCompilerRequestAndResponseSender> {
+        self.sierra_compiler_channel.take_rx()
+    }
+
     pub fn take_state_sync_tx(&mut self) -> Sender<StateSyncRequestAndResponseSender> {
         self.state_sync_channel.take_tx()
     }
@@ -75,6 +95,9 @@ pub fn create_node_channels() -> SequencerNodeCommunication {
     let (tx_batcher, rx_batcher) =
         channel::<BatcherRequestAndResponseSender>(DEFAULT_INVOCATIONS_QUEUE_SIZE);
 
+    let (tx_class_manager, rx_class_manager) =
+        channel::<ClassManagerRequestAndResponseSender>(DEFAULT_INVOCATIONS_QUEUE_SIZE);
+
     let (tx_gateway, rx_gateway) =
         channel::<GatewayRequestAndResponseSender>(DEFAULT_INVOCATIONS_QUEUE_SIZE);
 
@@ -87,11 +110,18 @@ pub fn create_node_channels() -> SequencerNodeCommunication {
     let (tx_mempool_p2p_propagator, rx_mempool_p2p_propagator) =
         channel::<MempoolP2pPropagatorRequestAndResponseSender>(DEFAULT_INVOCATIONS_QUEUE_SIZE);
 
+    let (tx_sierra_compiler, rx_sierra_compiler) =
+        channel::<SierraCompilerRequestAndResponseSender>(DEFAULT_INVOCATIONS_QUEUE_SIZE);
+
     let (tx_state_sync, rx_state_sync) =
         channel::<StateSyncRequestAndResponseSender>(DEFAULT_INVOCATIONS_QUEUE_SIZE);
 
     SequencerNodeCommunication {
         batcher_channel: ComponentCommunication::new(Some(tx_batcher), Some(rx_batcher)),
+        class_manager_channel: ComponentCommunication::new(
+            Some(tx_class_manager),
+            Some(rx_class_manager),
+        ),
         gateway_channel: ComponentCommunication::new(Some(tx_gateway), Some(rx_gateway)),
         l1_provider_channel: ComponentCommunication::new(
             Some(tx_l1_provider),
@@ -102,6 +132,10 @@ pub fn create_node_channels() -> SequencerNodeCommunication {
             Some(tx_mempool_p2p_propagator),
             Some(rx_mempool_p2p_propagator),
         ),
+        sierra_compiler_channel: ComponentCommunication::new(
+            Some(tx_sierra_compiler),
+            Some(rx_sierra_compiler),
+        ),
         state_sync_channel: ComponentCommunication::new(Some(tx_state_sync), Some(rx_state_sync)),
     }
 }