Skip to content

Commit

Permalink
fix(ci): always install Anvil (starkware-libs#3429)
Browse files Browse the repository at this point in the history
FIXME: This adds 3min to CI, we need to figure out how to cache it.
Initially, Anvil installed only when base layer and l1 provider were changed,
but this is naive, since the l1 provider tests are triggered also when
its dependecies are changed, for example infra crates.

Co-authored-by: Gilad Chase <[email protected]>
  • Loading branch information
giladchase and Gilad Chase authored Jan 19, 2025
1 parent 91959dc commit 8d7a10f
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,22 +28,6 @@ concurrency:
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
changes:
runs-on: starkware-ubuntu-20-04-medium
permissions:
pull-requests: read
outputs:
l1: ${{ steps.filter.outputs.l1 }}
steps:
- uses: actions/checkout@v4
- uses: dorny/paths-filter@v3
id: filter
with:
filters: |
l1:
- 'crates/starknet_l1_provider/**'
- 'crates/papyrus_base_layer/**'
code_style:
runs-on: starkware-ubuntu-20-04-medium
steps:
Expand Down Expand Up @@ -115,7 +99,6 @@ jobs:
- run: cargo test -p workspace_tests

run-tests:
needs: changes
runs-on: starkware-ubuntu-latest-large
steps:
- uses: actions/checkout@v4
Expand All @@ -141,7 +124,6 @@ jobs:
# know how to cache, so we're forced to reinstall it every time :(
- name: "Maybe install Anvil"
run: cargo install --git https://github.com/foundry-rs/foundry anvil --locked
if: needs.changes.outputs.l1 == 'true'

- name: "Run tests pull request"
if: github.event_name == 'pull_request'
Expand Down

0 comments on commit 8d7a10f

Please sign in to comment.