Fix broken metadata update API (#210)

landing-ai · Jul 9, 2024 · 8e33c56 · 8e33c56
1 parent 63fb490
commit 8e33c56
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/landingai/data_management/metadata.py b/landingai/data_management/metadata.py
@@ -3,9 +3,9 @@
 from landingai.data_management.client import METADATA_GET, METADATA_UPDATE, LandingLens
 from landingai.data_management.utils import (
     PrettyPrintable,
-    obj_to_dict,
-    metadata_to_ids,
     ids_to_metadata,
+    metadata_to_ids,
+    obj_to_dict,
 )
 
 
@@ -67,7 +67,7 @@ def update(
         ):
             raise ValueError("Missing required flags: {'media_ids'}")
 
-        if not input_metadata or len(input_metadata) == 0:
+        if not input_metadata:
             raise ValueError("Missing required flags: {'metadata'}")
 
         dataset_id = self._client.get_project_property(project_id, "dataset_id")
@@ -93,13 +93,13 @@ def update(
         return {
             "project_id": project_id,
             "metadata": ids_to_metadata(resp_data[0]["metadata"], id_to_metadata),
-            "media_ids": [media["objectId"] for media in resp_data],
+            "media_ids": [media["mediaId"] for media in resp_data],
         }
 
     def get(self, media_id: int) -> Dict[str, str]:
         """Return all the metadata associated with a given media."""
         resp = self._client._api(
-            METADATA_GET, params={"objectId": media_id, "objectType": "media"}
+            METADATA_GET, params={"mediaId": media_id, "objectType": "media"}
         )
         _, id_to_metadata = self._client.get_metadata_mappings(self._client._project_id)
         return {id_to_metadata[int(k)]: v for k, v in resp["data"].items()}

diff --git a/tests/data/responses/v1_set_metadata_multiple_medias.yaml b/tests/data/responses/v1_set_metadata_multiple_medias.yaml
@@ -16,7 +16,7 @@ responses:
     url: https://app.landing.ai/api/v1/metadata/get_metadata_by_projectId?projectId=30863867234314
 - response:
     auto_calculate_content_length: false
-    body: '{"code":0,"message":"","data":[{"orgId":376,"objectId":10300467,"objectType":"media","metadata":{"22024":"tom"}},{"orgId":376,"objectId":10300466,"objectType":"media","metadata":{"22024":"tom"}},{"orgId":376,"objectId":10300465,"objectType":"media","metadata":{"22024":"tom"}}]}'
+    body: '{"code":0,"message":"","data":[{"orgId":376,"mediaId":10300467,"objectType":"media","metadata":{"22024":"tom"}},{"orgId":376,"mediaId":10300466,"objectType":"media","metadata":{"22024":"tom"}},{"orgId":376,"mediaId":10300465,"objectType":"media","metadata":{"22024":"tom"}}]}'
     content_type: text/plain
     method: POST
     status: 200

diff --git a/tests/data/responses/v1_set_metadata_single_media.yaml b/tests/data/responses/v1_set_metadata_single_media.yaml
@@ -16,7 +16,7 @@ responses:
     url: https://app.landing.ai/api/v1/metadata/get_metadata_by_projectId?projectId=30863867234314
 - response:
     auto_calculate_content_length: false
-    body: '{"code":0,"message":"","data":[{"orgId":376,"objectId":10300467,"objectType":"media","metadata":{"22023":"train"}}]}'
+    body: '{"code":0,"message":"","data":[{"orgId":376,"mediaId":10300467,"objectType":"media","metadata":{"22023":"train"}}]}'
     content_type: text/plain
     method: POST
     status: 200