-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update github actions monthly with dependabot #346
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, @jlosito. I'm not certain of our general stance regarding automated changes, but this seems like a useful change to keep us informed about available updates.
I have one concern - by default, Dependabot opens individual pull requests for every new dependency update it detects. This could potentially end up spamming the repository with new PRs every time the monthly check occurs.
To prevent this, can we make use of the Grouped Version Updates feature? This would allow Dependabot to roll multiple changes into the same PR to keep things cleaner, and prevent possible conflicts when co-dependent packages each have pending updates.
For example:
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "monthly"
groups:
actions-dependencies:
patterns:
- "*"
We may also want to enhance this to suggest updates for the main project.
- package-ecosystem: "pip"
directory: "/"
schedule:
interval: "monthly"
groups:
prod-dependencies:
dependency-type: "production"
dev-dependencies:
dependency-type: "development"
@efriis |
- package-ecosystem: "github-actions" | ||
directory: "/" | ||
schedule: | ||
interval: "monthly" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change to weekly
? Also, this seem to only include updates to Github Actions, should we also add pip
, so it can cover python packages?
I believe it might be better to configure in the But this likely works too, and no issues with doing in a workflow! |
@3coins I had opened a similar change for the core lib. Right now it's in draft mode though because I haven't verified that all of the tests pass. |
@jlosito
|
Someone from LangChain team would be able to review that, but based on info from @efriis, it seems like the |
closed the monorepo one - yes to be clear we access them by enabling these settings (linking the langchain-aws one for convenience) |
This change will use dependabot to check for updates to any of the GitHub actions this project uses and submit pull requests with version bumps.