[Fix] Adding default description in tools #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 28, 2025 06:35
patilvishal0597
changed the title
patilvishal0597
force-pushed
the
issue-336-default-description-in-tools
branch
from
46e5957 to
9ab7d23
Compare
michaelnchin
suggested changes
Feb 6, 2025
There was a problem hiding this comment.
Thanks @patilvishal0597 - tested and looks good with several models that were previously failing.
Comment on lines
214
to
215
| if not tool["description"]: | ||
| tool["description"] = tool["name"] |
There was a problem hiding this comment.
Nit: can simplify to
tool["description"] = tool["description"] or tool["name"]
Comment on lines
1035
to
1036
| if "description" not in tool_spec or not tool_spec["description"]: | ||
| tool_spec["description"] = tool_spec["name"] |
There was a problem hiding this comment.
Nit: use dict.get()
tool_spec["description"] = tool_spec.get("description") or tool_spec["name"]
Comment on lines
219
to
220
| if "description" not in formatted or not formatted["description"]: | ||
| formatted["description"] = formatted["name"] |
There was a problem hiding this comment.
Nit: use dict.get()
formatted["description"] = formatted.get("description") or formatted["name"]
9ab7d23 to
9575ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tool name as default tool descriptions if description is an empty string or not passed
Fixes #336