adding bedrock token usage callback handler #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfgangcolsman
suggested changes
Jan 12, 2025
| from langchain_core.callbacks import BaseCallbackHandler | ||
| from langchain_core.outputs import LLMResult | ||
|
|
||
| MODEL_COST_PER_1K_INPUT_TOKENS = { |
There was a problem hiding this comment.
The list of models should be updated.
- Pricing for meta has changed
- New Anthropic models
- New Nova models
| f"Unknown model: {model_id}. Please provide a valid Bedrock model name." | ||
| "Known models are: " + ", ".join(MODEL_COST_PER_1K_INPUT_TOKENS.keys()) | ||
| ) | ||
| return (prompt_tokens / 1000) * MODEL_COST_PER_1K_INPUT_TOKENS[model_id] + ( |
There was a problem hiding this comment.
For Anthropic and Nova models, tokens for cache reads and writes have a different pricing
There was a problem hiding this comment.
I created a new PR that adds callback support to ChatBedrockConverse: #324
There was a problem hiding this comment.
@grvvrmtech, thank you for the submission. However, at this time, we are looking to avoid maintaining the hard-coded lists of models and prices on the front-end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding callback function for token usage counting, consulted openai callback.
Co-authored-by: Gaurav Verma [email protected]