Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add _agenerate implementation #12

Merged
merged 9 commits into from
Sep 17, 2024
Merged

Conversation

Wojciech-Rebisz
Copy link
Collaborator

Native support for agenetate method:

Example of usage:

watsonxllm = WatsonxLLM(
    model_id=MODEL_ID,
    url="https://us-south.ml.cloud.ibm.com",
    project_id=WX_PROJECT_ID,
)
response = await watsonxllm.agenerate(
    ["What color sunflower is?", "What color turtle is?"]
)

Test results:
Screenshot 2024-08-22 at 15 00 09

Unit tests: ✅
Linting: ✅
Format: ✅

@Wojciech-Rebisz
Copy link
Collaborator Author

It works, but due to planned changes to the SDK, it may be affected by new behavior. Until then, I'm marking it as draft.

@Wojciech-Rebisz Wojciech-Rebisz marked this pull request as draft August 22, 2024 15:06
@Wojciech-Rebisz Wojciech-Rebisz marked this pull request as ready for review September 13, 2024 09:00
@Wojciech-Rebisz Wojciech-Rebisz changed the title Add _agenerate implementation feat: Add _agenerate implementation Sep 13, 2024
@Wojciech-Rebisz
Copy link
Collaborator Author

It looks like the SDK version 1.1.9 is not yet available on pypi.
If it's already there, please update poetry.lock (can be done with simple poetry update command).

# Conflicts:
#	libs/ibm/langchain_ibm/llms.py
#	libs/ibm/poetry.lock
#	libs/ibm/pyproject.toml
Copy link
Collaborator

@Mateusz-Switala Mateusz-Switala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MateuszOssGit MateuszOssGit merged commit 240f370 into main Sep 17, 2024
12 checks passed
@MateuszOssGit MateuszOssGit deleted the dev-add-native-agenerate branch September 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants