Core: Fix __add__ for concatting two BaseMessageChunk's #29531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The change allows you to use the overloaded
+
operator correctly when+
ing two BaseMessageChunk subclasses. Without this you must instantiate a subclass for it to work.Which feels... wrong. Base classes should be decoupled from sub classes and should have in no way a dependency on them.
Issue:
You can't
+
a BaseMessageChunk with a BaseMessageChunke.g. this will explode
In case anyone ran into this issue themselves, it's probably best to use the AIMessageChunk:
a la
Dependencies:
None!
Twitter handle:
aaron_vogler
Keeping these for later if need be: