Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FalkorDB support #2774

Closed
wants to merge 3,016 commits into from
Closed

Add FalkorDB support #2774

wants to merge 3,016 commits into from

Conversation

gkorland
Copy link

@gkorland gkorland commented Oct 3, 2023

Adding FalkorDB Graph store support

Ref to: #2741

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Dec 15, 2024 8:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Dec 15, 2024 8:36am

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Oct 3, 2023
@@ -0,0 +1,18 @@
/* eslint-disable no-process-env */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is flagging the addition of code that accesses an environment variable via process.env in the falkordb_graph.int.test.ts file for maintainers to review.

@jacoblee93
Copy link
Collaborator

Looks broadly reasonable - feel free to mark out of draft. Don't forget to run yarn lint and yarn format.

Might be good to coordinate the base class with Python as well? CC @baskaryan

@gkorland gkorland marked this pull request as ready for review October 11, 2023 09:13
@gkorland
Copy link
Author

@jacoblee93 formatted the code

jacoblee93 and others added 20 commits October 2, 2024 12:18
jacoblee93 and others added 24 commits December 5, 2024 11:11
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 15, 2024
const typedocPath = path.join(entrypointDir, "typedoc.json");

if (!fs.existsSync(typedocPath)) {
fs.writeFileSync(typedocPath, "{}\n");

Check failure

Code scanning / CodeQL

Potential file system race condition

The file may have changed since it [was checked](1).

// Check if the `./typedoc.json` file exists, since it is gitignored by default
if (!fs.existsSync("./typedoc.json")) {
fs.writeFileSync("./typedoc.json", "{}\n");

Check failure

Code scanning / CodeQL

Potential file system race condition

The file may have changed since it [was checked](1).
content = content
.replace(IGNORED_CELL_REGEX, "")
.replace(LC_TS_IGNORE_REGEX, "");
fs.writeFileSync(renamedFilepath, content);

Check failure

Code scanning / CodeQL

Potential file system race condition

The file may have changed since it [was checked](1).
import { TaskadeProjectLoader } from "@langchain/community/document_loaders/web/taskade";

const loader = new TaskadeProjectLoader({
personalAccessToken: "TASKADE_PERSONAL_ACCESS_TOKEN", // or load it from process.env.TASKADE_PERSONAL_ACCESS_TOKEN

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "TASKADE_PERSONAL_ACCESS_TOKEN" is used as [authorization header](1).
options: {
timeout: 10000,
headers: {
Authorization: "Bearer YOUR_TOKEN",

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "Bearer YOUR_TOKEN" is used as [authorization header](1).
type: "postgres",
host: "127.0.0.1",
port: 5432,
user: "myuser",

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "myuser" is used as [user name](1).
const reusablePool = new pg.Pool({
host: "127.0.0.1",
port: 5433,
user: "myuser",

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "myuser" is used as [user name](1).
const poolConfig = {
host: "127.0.0.1",
port: 5432,
user: "myuser",

Check failure

Code scanning / CodeQL

Hard-coded credentials

The hard-coded value "myuser" is used as [user name](1).
@gkorland
Copy link
Author

gkorland commented Dec 15, 2024

Replaced with #7367

@gkorland gkorland closed this Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.