-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(community): Add support for connecting to remote browser via Websocket #7603
Open
mikiastilahun
wants to merge
3
commits into
langchain-ai:main
Choose a base branch
from
mikiastilahun:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
This PR changes 30-99 lines, ignoring generated files.
label
Jan 27, 2025
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:improvement
Medium size change to existing code to handle new use-cases
label
Jan 27, 2025
…reenshot functionality
jacoblee93
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me, thank you!
jacoblee93
changed the title
feat(puppeteer): Add support for connecting to remote browser via Web…
feat(community): Add support for connecting to remote browser via Websocket
Jan 29, 2025
Could you run |
I got it nvm |
Getting some build errors:
|
jacoblee93
added
close
PRs that need one or two touch-ups to be ready
and removed
lgtm
PRs that are ready to be merged as-is
labels
Jan 30, 2025
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:improvement
Medium size change to existing code to handle new use-cases
close
PRs that need one or two touch-ups to be ready
size:M
This PR changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Connect to an Existing Browser Instance
Summary
This PR introduces functionality to connect to an already running browser instance instead of launching a new one each time. This is particularly useful for users who have a separate Chrome instance running and prefer to connect to it directly for efficiency and custom workflows.
Key Features
Use Case Example
Contributor:
Twitter/X: @Mike_T_Abebe