Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weaviate): Migrate to the new Weaviate client version 3 #7630

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

my8bit
Copy link
Contributor

@my8bit my8bit commented Jan 30, 2025

As stated in the official documentation for the Weaviate TypeScript client they are deprecating the v2 version of the client.

The v3 client is the current TypeScript client. If you have code written for the v2 client, you should migrate it to v3.

The v2 client version is still available in npm, however you should not use it to begin new projects.

Source: Weaviate Documentation

This MR is implementing the necessary changes to be able to use the v3 of the client.

Copy link

vercel bot commented Jan 30, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jan 30, 2025 11:00am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jan 30, 2025 11:00am

@my8bit my8bit changed the title feat: migrate to the new Weaviate client version 3 feat(weaviate): Migrate to the new Weaviate client version 3 Jan 30, 2025
@hsm207
Copy link
Contributor

hsm207 commented Jan 31, 2025

@my8bit what else is needs to be implements to get this ready for review?

@my8bit
Copy link
Contributor Author

my8bit commented Jan 31, 2025

Hey @hsm207, thanks for reaching out. There is a still usage of the old v2 client for compatibility.

From the functional perspective to keep the behavior as close as possible to v2:

  • Enabled support of the filter option for delete method have to support the filter parameter
  • Support to deletion of the tenant if specified and still applicable
  • Enabled support of the filter option for similaritySearchVectorWithScoreAndEmbedding method
  • Support of the tenant for similaritySearchVectorWithScoreAndEmbedding if specified and still applicable
  • Correctly passing the distance and vector from search results to the final Document

@hsm207
Copy link
Contributor

hsm207 commented Jan 31, 2025

thanks @my8bit for clarifying. I'd like to try making a contribution. Can you add me and @malgamves to your fork so we can collab on this PR?

@my8bit
Copy link
Contributor Author

my8bit commented Jan 31, 2025

hsm207

Thanks! I've sent invites with write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants