fix(google-genai): Update fileData & inlineData to kebab case as per REST API requirements #7631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
the
auto:nit
hongkongkiwi
changed the title
Google Gemini HTTP API requires file_data and inline_data to be in kebab case. This is different to the SDKs which use Snake case. It is possible to use Snake case but with mixed results (e.g. inlineData works, but fileData does not), however officially both should be kebab (see Shell docs): https://ai.google.dev/api/files and have been tested working.
|
Although this works, I misunderstood that we do actually use the official sdk client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google Gemini HTTP API (which is what we are using in this module) actually requires file_data and inline_data to be in kebab case. This is different to the SDKs which use Snake case.
It is possible to use Snake case for some things but with mixed results (e.g. inlineData works, but fileData does not), however officially both should be kebab (see Shell docs): https://ai.google.dev/api/files and have been tested working.
Previously, I had contributed a fix which added the fileData #7621 , but it was using snake case which is wrong and didn't actually work consistently.
So this fix converts both inline_data and file_data to kebab case, which is what the HTTP API wants. Google docs are sparse, but REST/Shell examples always show kebab case for these fields.