Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feedback buttons to stream_log runs #203

Merged
merged 16 commits into from
Nov 28, 2023
Merged

Add feedback buttons to stream_log runs #203

merged 16 commits into from
Nov 28, 2023

Conversation

dqbd
Copy link
Collaborator

@dqbd dqbd commented Nov 10, 2023 •
edited
Loading

CleanShot.2023-11-28.at.00.41.36.mp4

TODO:

  • We need to expose the ability to get and remove a specific run based off an ID, otherwise multiple clicking will send multiple feedbacks
  • Hide buttons if LangSmith not configured or feedback endpoint not exposed

@cla-bot cla-bot bot added the cla-signed label Nov 10, 2023
@dqbd dqbd changed the title Add feedback buttons to stream_log runs DRAFT: Add feedback buttons to stream_log runs Nov 10, 2023
@dqbd dqbd changed the title DRAFT: Add feedback buttons to stream_log runs Add feedback buttons to stream_log runs Nov 10, 2023
jakerachleff
jakerachleff approved these changes Nov 10, 2023
View reviewed changes
langserve/playground.py Outdated Show resolved Hide resolved
langserve/schema.py Outdated Show resolved Hide resolved
langserve/playground/src/components/feedback/CorrectnessFeedback.tsx Outdated Show resolved Hide resolved
@dqbd dqbd requested a review from jakerachleff November 27, 2023 23:33
@dqbd dqbd merged commit a51a6c0 into main Nov 28, 2023
10 checks passed
@dqbd dqbd deleted the dqbd/feedback-playground branch November 28, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakerachleff jakerachleff jakerachleff approved these changes

@eyurtsev eyurtsev Awaiting requested review from eyurtsev

@nfcampos nfcampos Awaiting requested review from nfcampos

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dqbd @jakerachleff @eyurtsev