Enable/disable endpoints #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakerachleff
reviewed
Dec 5, 2023
| *, | ||
| enabled_endpoints: Optional[Sequence[EndpointName]] = None, | ||
| disabled_endpoints: Optional[Sequence[EndpointName]] = None, | ||
| enable_feedback_endpoint: bool = False, |
jakerachleff
reviewed
Dec 5, 2023
| endpoint_configuration = _EndpointConfiguration( | ||
| enabled_endpoints=enabled_endpoints, | ||
| disabled_endpoints=disabled_endpoints, | ||
| enable_feedback_endpoint=enable_feedback_endpoint, |
There was a problem hiding this comment.
(1) compatibility, (2) and for me this is an endpoint that should be default off
Regardless, if you're happy with this set up, i can update the tests and commit to this design. I can follow up with a PR to update handling of enable_feedback_point
jakerachleff
reviewed
Dec 5, 2023
| per_req_config_modifier: Optional[PerRequestConfigModifier] = None, | ||
| enable_feedback_endpoint: bool = False, |
There was a problem hiding this comment.
Should we get rid of this and see who complains? I feel like no one is probably using this outside of people we've actually pointed here, and it make the API gross to have it along with enabled/disabled endpoints...
I feel like we're really early on for backwards compat issues on langserve. Ideally we could do like minor version bumps or something and make small changes on compat
jakerachleff
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optionality to enable/disable endpoints