Update feedback enabled endpoint #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
commented
Dec 15, 2023
langserve/api_handler.py
Outdated
| This endpoint is private since it will be deprecated in the future. | ||
|
|
||
| """ | ||
| if not self._enable_feedback_endpoint or not tracing_is_enabled(): |
There was a problem hiding this comment.
swap order of conditional for short circuiting -- self._enable_feedback_endpoint is a local attribute, with tracing_is_enabled() could include some hidden cost (at the moment there's no difference)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update feedback endabled endpoint behavior