Expose API Handler #333
Expose API Handler #333
Conversation
eyurtsev
commented
Dec 15, 2023
•
eyurtsev
commented
- Exposes the underlying API handler, so that developers can use it directly.
- Document more of the API handler methods.
- Adds an optional server_config to each endpoint on the API handler to provide developers with maximal flexibility in terms of specifying configuration dynamically.
| @@ -381,7 +381,14 @@ def _add_callbacks( | |||
| config["callbacks"].extend(callbacks) | |||
|
|
|||
|
|
|||
| class _APIHandler: | |||
| _MODEL_REGISTRY = {} | |||
There was a problem hiding this comment.
what is this used for?
There was a problem hiding this comment.
Even though I wrote the code I was wondering the same today :)
I'll try update the doc-string later -- it was needed to fix up some behavior associated with fast api / open api specs and having the same pydantic model appear multiple times causing the open api docs to crash, so instead this helps to look up an existing model if it was already seen (instead of creating a duplicate)
|
|
||
| chain = RunnableLambda(add_one) | ||
|
|
||
| api_handler = APIHandler(chain, "/simple") |
There was a problem hiding this comment.
Is there a more realistic scenario we can show this with?
There was a problem hiding this comment.
Yeah probably should!
I think another example though -- this example has complexity coming from the doc-generation itself.
There was a problem hiding this comment.
Should we name the example to make it more clear then it's about doc generation? I feel like people may not understand why this example exists / what it does that's special
