Fixes associated with feedback endpoint #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eyurtsev
commented
Apr 3, 2024
eyurtsev
commented
- Fixes langsmith client not being enabled if token feedback was specified
- Add unit test for token feedback endpoint
- Fix schema for token feedback to accept a str in addition to a UUID
- Add metadata even to astream log with token feedback information
hemslo
reviewed
Apr 25, 2024
| @@ -1229,6 +1243,18 @@ async def _stream_log() -> AsyncIterator[dict]: | |||
| "data": self._serializer.dumps(data).decode("utf-8"), | |||
| "event": "data", | |||
| } | |||
|
|
|||
| # Send a metadata event as soon as possible | |||
| if not has_sent_metadata and self._enable_feedback_endpoint: | |||
There was a problem hiding this comment.
If _token_feedback_enabled is False but _enable_feedback_endpoint is True, task will be None, causing AssertionError("Feedback token task was not created.") always raise. Do you mean to check
_token_feedback_enabled here?
Can be reproduced by using the default example in
Lines 399 to 406 in 109445b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.