add webhooks modal example #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charlesfrye
reviewed
Apr 17, 2024
charlesfrye
reviewed
Apr 17, 2024
charlesfrye
reviewed
Apr 17, 2024
charlesfrye
reviewed
Apr 17, 2024
charlesfrye
reviewed
Apr 17, 2024
| @@ -77,3 +77,116 @@ When delivering events to your webhook endpoint we follow these guidelines | |||
| - If your endpoint returns a 5xx status code in less than 5 seconds we retry up to 2 times with exponential backoff. | |||
There was a problem hiding this comment.
There are some cases where a Modal web endpoint might not spin up and ACK in less than 5 seconds. To avoid that, you can put keep_warm on the stub.function so you don't hit cold boots, but then you lose autoscaling. You can also reduce the chance of by putting less work in the path of the request -- e.g. defining a separate stub.function to handle a run and using Function.spawn to launch it as a background task, which means you can get to the ACK faster.
I'll include that in my example, so no need to put it in here, just wanted to raise the issue.
charlesfrye
reviewed
Apr 17, 2024
charlesfrye
reviewed
Apr 17, 2024
charlesfrye
suggested changes
Apr 17, 2024
hwchase17
changed the title
nfcampos
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.