Skip to content

fix: send error instead of extra #872

fix: send error instead of extra

fix: send error instead of extra #872

Triggered via pull request January 17, 2025 21:45
Status Success
Total duration 5m 17s
Artifacts

py-bench.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 2 notices
benchmark
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Benchmark results: python/langsmith/client.py#L1
........... create_5_000_run_trees: Mean +- std dev: 636 ms +- 51 ms ........... create_10_000_run_trees: Mean +- std dev: 1.33 sec +- 0.09 sec ........... create_20_000_run_trees: Mean +- std dev: 2.62 sec +- 0.11 sec ........... dumps_class_nested_py_branch_and_leaf_200x400: Mean +- std dev: 715 us +- 13 us ........... dumps_class_nested_py_leaf_50x100: Mean +- std dev: 24.9 ms +- 0.2 ms ........... dumps_class_nested_py_leaf_100x200: Mean +- std dev: 105 ms +- 3 ms ........... dumps_dataclass_nested_50x100: Mean +- std dev: 25.2 ms +- 0.3 ms ........... WARNING: the benchmark result may be unstable * the standard deviation (17.2 ms) is 24% of the mean (72.6 ms) Try to rerun the benchmark with more runs, values and/or loops. Run 'python -m pyperf system tune' command to reduce the system jitter. Use pyperf stats, pyperf dump and pyperf hist to analyze results. Use --quiet option to hide these warnings. dumps_pydantic_nested_50x100: Mean +- std dev: 72.6 ms +- 17.2 ms ........... dumps_pydanticv1_nested_50x100: Mean +- std dev: 196 ms +- 7 ms
Comparison against main: python/langsmith/client.py#L1
+-----------------------------------------------+----------+------------------------+ | Benchmark | main | changes | +===============================================+==========+========================+ | dumps_pydanticv1_nested_50x100 | 220 ms | 196 ms: 1.12x faster | +-----------------------------------------------+----------+------------------------+ | create_5_000_run_trees | 658 ms | 636 ms: 1.03x faster | +-----------------------------------------------+----------+------------------------+ | create_20_000_run_trees | 2.66 sec | 2.62 sec: 1.01x faster | +-----------------------------------------------+----------+------------------------+ | dumps_class_nested_py_leaf_50x100 | 25.2 ms | 24.9 ms: 1.01x faster | +-----------------------------------------------+----------+------------------------+ | dumps_dataclass_nested_50x100 | 25.5 ms | 25.2 ms: 1.01x faster | +-----------------------------------------------+----------+------------------------+ | dumps_class_nested_py_leaf_100x200 | 105 ms | 105 ms: 1.00x slower | +-----------------------------------------------+----------+------------------------+ | create_10_000_run_trees | 1.31 sec | 1.33 sec: 1.01x slower | +-----------------------------------------------+----------+------------------------+ | dumps_class_nested_py_branch_and_leaf_200x400 | 706 us | 715 us: 1.01x slower | +-----------------------------------------------+----------+------------------------+ | dumps_pydantic_nested_50x100 | 68.3 ms | 72.6 ms: 1.06x slower | +-----------------------------------------------+----------+------------------------+ | Geometric mean | (ref) | 1.01x faster | +-----------------------------------------------+----------+------------------------+