Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): add datasetVersion parameter to listProjects #1391

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(js): add datasetVersion parameter to listProjects #1391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions js/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@
// If there is an item on the queue we were unable to pop,
// just return it as a single batch.
if (popped.length === 0 && this.items.length > 0) {
const item = this.items.shift()!;

Check warning on line 432 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

Forbidden non-null assertion
popped.push(item);
poppedSizeBytes += item.size;
this.sizeBytes -= item.size;
Expand Down Expand Up @@ -862,7 +862,7 @@
if (this._serverInfo === undefined) {
try {
this._serverInfo = await this._getServerInfo();
} catch (e) {

Check warning on line 865 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

'e' is defined but never used. Allowed unused args must match /^_/u
console.warn(
`[WARNING]: LangSmith failed to fetch info on supported operations. Falling back to batch operations and default limits.`
);
Expand Down Expand Up @@ -1597,7 +1597,7 @@
treeFilter?: string;
isRoot?: boolean;
dataSourceType?: string;
}): Promise<any> {

Check warning on line 1600 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

Unexpected any. Specify a different type
let projectIds_ = projectIds || [];
if (projectNames) {
projectIds_ = [
Expand Down Expand Up @@ -1885,7 +1885,7 @@
`Failed to list shared examples: ${response.status} ${response.statusText}`
);
}
return result.map((example: any) => ({

Check warning on line 1888 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

Unexpected any. Specify a different type
...example,
_hostUrl: this.getHostUrl(),
}));
Expand Down Expand Up @@ -2022,7 +2022,7 @@
}
// projectId querying
return true;
} catch (e) {

Check warning on line 2025 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

'e' is defined but never used. Allowed unused args must match /^_/u
return false;
}
}
Expand Down Expand Up @@ -2121,6 +2121,7 @@
nameContains,
referenceDatasetId,
referenceDatasetName,
datasetVersion,
referenceFree,
metadata,
}: {
Expand All @@ -2129,9 +2130,10 @@
nameContains?: string;
referenceDatasetId?: string;
referenceDatasetName?: string;
datasetVersion?: string;
referenceFree?: boolean;
metadata?: RecordStringAny;
} = {}): AsyncIterable<TracerSession> {
} = {}): AsyncIterable<TracerSessionResult> {
const params = new URLSearchParams();
if (projectIds !== undefined) {
for (const projectId of projectIds) {
Expand All @@ -2152,13 +2154,16 @@
});
params.append("reference_dataset", dataset.id);
}
if (datasetVersion !== undefined) {
params.append("dataset_version", datasetVersion);
}
if (referenceFree !== undefined) {
params.append("reference_free", referenceFree.toString());
}
if (metadata !== undefined) {
params.append("metadata", JSON.stringify(metadata));
}
for await (const projects of this._getPaginated<TracerSession>(
for await (const projects of this._getPaginated<TracerSessionResult>(
"/sessions",
params
)) {
Expand Down Expand Up @@ -3397,7 +3402,7 @@
async _logEvaluationFeedback(
evaluatorResponse: EvaluationResult | EvaluationResults,
run?: Run,
sourceInfo?: { [key: string]: any }

Check warning on line 3405 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

Unexpected any. Specify a different type
): Promise<[results: EvaluationResult[], feedbacks: Feedback[]]> {
const evalResults: Array<EvaluationResult> =
this._selectEvalResults(evaluatorResponse);
Expand Down Expand Up @@ -3436,7 +3441,7 @@
public async logEvaluationFeedback(
evaluatorResponse: EvaluationResult | EvaluationResults,
run?: Run,
sourceInfo?: { [key: string]: any }

Check warning on line 3444 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

Unexpected any. Specify a different type
): Promise<EvaluationResult[]> {
const [results] = await this._logEvaluationFeedback(
evaluatorResponse,
Expand Down Expand Up @@ -3932,7 +3937,7 @@

public async createCommit(
promptIdentifier: string,
object: any,

Check warning on line 3940 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

Unexpected any. Specify a different type
options?: {
parentCommitHash?: string;
}
Expand Down Expand Up @@ -4164,7 +4169,7 @@
isPublic?: boolean;
isArchived?: boolean;
}
): Promise<Record<string, any>> {

Check warning on line 4172 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

Unexpected any. Specify a different type
if (!(await this.promptExists(promptIdentifier))) {
throw new Error("Prompt does not exist, you must create it first.");
}
Expand All @@ -4175,7 +4180,7 @@
throw await this._ownerConflictError("update a prompt", owner);
}

const payload: Record<string, any> = {};

Check warning on line 4183 in js/src/client.ts

View workflow job for this annotation

GitHub Actions / Check linting 

Unexpected any. Specify a different type

if (options?.description !== undefined)
payload.description = options.description;
Expand Down
Loading