Draft of zstd compression in the PyO3 client implementation. #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not yet tested end-to-end. Will continue on this tomorrow -- this is just for initial "vibe check" review purposes. Will likely need to have its Rust and Python parts merged separately, since the Python client library is pinned to a specific Rust PyO3 client version and we're making a major breaking change to the PyO3 client's interface by adding the compression level argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet tested end-to-end. Will continue on this tomorrow -- this is just for initial "vibe check" review purposes.
Will likely need to have its Rust and Python parts merged separately, since the Python client library is pinned to a specific Rust PyO3 client version and we're making a major breaking change to the PyO3 client's interface by adding the compression level argument.