Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): remove default created_at from createExample method. #1406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tendev-liam
Copy link
Contributor

@tendev-liam tendev-liam commented Jan 10, 2025

Issue:
Examples created from the createExample method of the JS client are created with 3 digits of fractional seconds.

How Issue Presents:
The endpoint to get dataset versions (https://api.smith.langchain.com/api/v1/datasets/{dataset_id}/version) always responds with 6 digits of fractional seconds.
When filtering expirements by dataset ID the langsmith frontend will use one of the resuls from the get dataset verions i.e the timestamp with 6 digits.
When a expirement is being tagged with a dataset version it will use the modified_at key of an example which if created from the JS client will only contain 3 digits of precison.

Fix:
Hand over the creation of the createExample created_at timestamp to langsmith server.

@jacoblee93
Copy link
Collaborator

Sorry about the delay, I think this looks good but CC @dqbd for a more informed opinion

@jacoblee93 jacoblee93 requested a review from dqbd January 15, 2025 17:47
@tendev-liam
Copy link
Contributor Author

tendev-liam commented Jan 15, 2025

@dqbd
I made this PR as an attempted fix for this issue and it appeared to work initially but later as mentioned in this comment I think this is just a partial solve.
Can we merge now or do we need to investigate further?

@jacoblee93
Copy link
Collaborator

Hmm yeah let's try to make a real fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants