Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Rust tracing client more robust to errors. #1424

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Make Rust tracing client more robust to errors. #1424

wants to merge 13 commits into from

Conversation

obi1kenobi
Copy link
Collaborator

@obi1kenobi obi1kenobi commented Jan 15, 2025 •
edited
Loading

Stacked on top of #1421, #1419, #1414.

  • Track whether the compressed stream is polluted or intact on errors.
  • Include the HTTP error message in HTTP errors.
  • Mark the API key header as sensitive, so it isn't printed in logs.
  • Retry network/server errors, and make processor run() infallible.
  • Add lint suppression on not-yet-used error variant data.

obi1kenobi and others added 13 commits January 15, 2025 16:38
@obi1kenobi
Switch PyO3 to streaming zstd-compressed multipart Rust client.
fcb3300
@obi1kenobi
Switch to bounded channel and re-add queue_capacity.
610ebd2
@obi1kenobi
Remove the async and non-streaming blocking tracing clients.
bcf6a6d
@obi1kenobi
Remove dead code and benchmarks for deleted code.
06e84c9
@obi1kenobi
Re-vendor pyo3 at the v0.23.4 commit (#1421)
70b982e 
`orjson` still uses non-published functionality in `pyo3`, so we have to
keep it vendored.

Update our vendored `pyo3` to v0.23.4, to pick up the soundness fixes in
v0.23.3.
@obi1kenobi
Track whether the compressed stream is polluted or intact on errors.
5aae376
@obi1kenobi
Include the HTTP error message in HTTP errors.
3014107
@obi1kenobi
Mark the API key header as sensitive, so it isn't printed in logs.
8a24154
@obi1kenobi
Retry network/server errors, and make processor run() infallible.
b05339c
@obi1kenobi
Add lint suppression on not-yet-used error variant data.
d9e7e3a
@obi1kenobi
Reformat code.
0ed2b84
@obi1kenobi
Use 0-sized channel for drain coordination. Print errors to stderr.
b340b76
@obi1kenobi
Merge branch 'main' into pg/rework-tracing-errors
690640b
@obi1kenobi obi1kenobi marked this pull request as ready for review January 16, 2025 01:21
@obi1kenobi obi1kenobi requested a review from agola11 January 17, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agola11 agola11 Awaiting requested review from agola11

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@obi1kenobi