Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file parsing based on mimetype #14

Merged
merged 11 commits into from
Nov 10, 2023
Merged

Add file parsing based on mimetype #14

merged 11 commits into from
Nov 10, 2023

Conversation

eyurtsev
Copy link
Contributor

@eyurtsev eyurtsev commented Nov 9, 2023 •
edited
Loading

This PR adds basic file parsing capabilities to experiment with

  • Guess mimetype of uploaded content
  • Apply a parser to the content to convert into a document

@cla-bot cla-bot bot added the cla-signed label Nov 9, 2023
@eyurtsev eyurtsev requested a review from hwchase17 November 10, 2023 03:37
@eyurtsev eyurtsev changed the title Work in progress on ingestion Add file parsing Nov 10, 2023
@eyurtsev eyurtsev changed the title Add file parsing Add file parsing based on mimetype Nov 10, 2023
hwchase17
hwchase17 reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

havent tested it this but largely looks good to me

most of logic is in agent-executor which i like

@eyurtsev eyurtsev merged commit f4dc73b into harrison/stateful Nov 10, 2023
@eyurtsev eyurtsev deleted the eugene/update_ingestion branch November 10, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfcampos nfcampos Awaiting requested review from nfcampos

@hwchase17 hwchase17 Awaiting requested review from hwchase17

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eyurtsev @hwchase17