Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with chat-input-area clearing during Responding state. #12352

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Woo0ood
Copy link
Contributor

@Woo0ood Woo0ood commented Jan 3, 2025

Summary

Resolves #11849

This PR is a resubmission as requested, as part of the now-closed #11850 .

Fixed

  • Fix the issue where the chat-input-area was cleared in response state
    • Fixed the issue where the input box content was cleared after sending a message in response state. Now, it will check if the state is in response mode, and if so, it will display a prompt and retain the input box content.

Modification Details

This section was automatically generated by GitHub Copilot actions.

This pull request includes changes to the ChatInputArea component to handle the scenario when a response is already being processed. The most important changes include adding a new isResponding property to the component's props and implementing a check to notify the user if a response is in progress.

Enhancements to ChatInputArea component:

Integration with Chat component:

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Fixed an issue where sending a message while in the Responding state would clear the input box content. Now, it checks if the state isResponding, and if true, it shows a prompt and does not clear the input box.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 3, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 4, 2025
@crazywoola crazywoola merged commit 6c9e6a3 into langgenius:main Jan 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Various Synchronization and Display Issues in Components
2 participants