Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issues related to the deletion of conversation_id #12488 #12610

Closed
wants to merge 0 commits into from

Conversation

jiandanfeng
Copy link
Contributor

Summary

When the conversation_id is deleted, chat with conversation_id again, returning Conversation Not Exists.

Fixes #12488

Screenshots

Before
Can chat normally with deleted conversation_id
After
image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Jan 10, 2025
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please fix the lint issue
  • I notice that you only updated the logic of app_generator in advanced_chat, however other types of application should be fixed as well.

@jiandanfeng jiandanfeng force-pushed the fix-bug-12488 branch 2 times, most recently from e48cbb9 to 3644b1b Compare January 13, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues related to the deletion of conversation_id
2 participants