-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inertia support #16
Comments
Ok I was too quick, actually I found the inertia response adapter you guys created on a different repo, now what's left is a little usage guide |
I think the single file package should be included in the main repo. Only 1 file, no need to make it a separate composer package to add to the list. |
Indeed, PHP is not like JS, don't need to cut down in size as long as its only used when the user is using Inertia in his Laravel setup |
The issue is not the source files but the additional dependencies that the Inertia renderer has. Pulling it into the main package would mean that every project that installs Arcanist now automatically also depends on Inertia. |
Having a separate package also have some issues:
But I see the problem now, automatically adding Inertia as a dependency is worse. No workaround? |
Why not use Laravel's container instead of depending from the package itself? I see this used in some packages, they also add the dependency as suggested instead of a requirement. Edit: I see that you guys use the Facade way, I would suggest to use the global function helper |
The I'm going to close this issue for now since Arcanist does support Inertia.js (in fact, that was my primary use-case when writing the package) and the conversation got a bit derailed. I saw that you also opened an issue in the |
Hi there, I see this package very useful for something my company is trying to do
Also we're using InertiaJS, it will be very nice to have compatibility with this package like the "Custom renderers" (which seems wip in the docs page) and sharing data will be much easier reusing Inertia's methods.
The text was updated successfully, but these errors were encountered: