Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with main repo #5

Open
jonagoldman opened this issue Jul 20, 2021 · 1 comment
Open

Merge with main repo #5

jonagoldman opened this issue Jul 20, 2021 · 1 comment

Comments

@jonagoldman
Copy link

The renderer is just one file, but:

  • its not configurable (e.g. change Inertia pages path, change route names, ...)
  • its one more composer dependency.
  • its one more Service Provider that needs to be loaded.

So would really like to merge it with the main repo so we can have a nice (OCD free) Renderer folder that would look like this:

  • /Renderer
    • BladeResponseRenderer.php
    • FakeResponseRenderer.php
    • InertiaResponseRenderer.php

:)

@ksassnowski
Copy link
Contributor

I’ve addressed this in another issue on the main repository already. Arcanist itself does not depend on Inertia at all, so including this in the main repo without any changes would mean that every project that depends on Arcanist now automatically depends on Inertia as well.

The solution to this is probably to add inertiajs/inertia-laravel package to the suggests section of the main package's composer.json and mention this in the installation instructions. This would be a BC break, however, so I’ve been putting this off until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants