Capture notification duration #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timacdonald
reviewed
Feb 17, 2025
src/Sensors/NotificationSensor.php
Outdated
| if (str_contains($event->notification::class, "@anonymous\0")) { | ||
| $class = Str::before($event->notification::class, "\0"); | ||
| } else { | ||
| $class = $event->notification::class; | ||
| } | ||
|
|
||
| $this->duration ??= (int) round(($now - $this->startTime) * 1_000_000); |
There was a problem hiding this comment.
Do we need the ??= operator here instead of =?
Looking at this, it seems we would always want to recompute the duration at this point for notifications?
Tests seem to pass without it.
There was a problem hiding this comment.
No, we don't. I can't imagine a scenario where we want to reuse the same duration. I've updated the code. Thank you for spotting this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't capture notification durations.
This PR captures the duration by listening to the
NotificationSendingandNotificationSentevents and calculating the difference between their timestamps.We cannot capture failed notifications because the framework doesn't dispatch the
NotificationFailedevent. When a notification fails, it will show up as an exception record on the Nightwatch app.