S3 docs #521
S3 docs #521
Conversation
|
| "storage": { | ||
| "type": "s3", | ||
| "bucket": <your-s3-bucket-name>, | ||
| "region": <your-s3-bucket-region>, |
There was a problem hiding this comment.
Recommend using LATITUDE__ env variables here
There was a problem hiding this comment.
I recommended it using a Note underneath the code.
There was a problem hiding this comment.
I see but what's the point recommending here the non-secure way
There was a problem hiding this comment.
Testing, for example. That's what I have been using
There was a problem hiding this comment.
Yes, but this is dangerous. You can test by setting the values in .env vars when we have all the pieces. Docs should not encourage storing secrets in git. People can commit it by mistake
| s3: | ||
| accessKeyId: <your-access-key-id> | ||
| secretAccessKey: <your-secret-access-key> | ||
| region: <your-region> |
csansoon
force-pushed
the
temp-parquet-files
branch
from
e907c53 to
a2a4949
Compare
Describe your changes
DOCS!
Checklist before requesting a review