-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to V5 #115
Update to V5 #115
Conversation
WIP commit of all changes
fix: first entry in flag list not expanding
fix: first entry in flag list not expanding
update publish action
clean up targeting implementation
add: osmo icon simplify multiple functions add: released flags highlights
add: sort project in configuration based on current add status bar and trigger config command
remove: unused comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new features and ctx refactor looks good from my understanding. Most of my review is focussed on cleaning up commented out code. It might be worth pulling that out into a separate branch if we are planning to keep some of that around.
import { registerCommand } from '../utils'; | ||
|
||
export function checkCodeRefs(ctx: ExtensionContext) { | ||
const disposable = registerCommand('extension.checkLaunchDarkly', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth using const
s for the command IDs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ldhenry That's a great idea. It might take a bit of effort for cleaning up. Would it work if I did that as a patch release in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup that works for me.
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
List of updates are included in CHANGELOG. This version is a significant rewrite of v4 except for how around data with the FlagStore is handled.