Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to V5 #115

Merged
merged 48 commits into from
Feb 6, 2024
Merged

Update to V5 #115

merged 48 commits into from
Feb 6, 2024

Conversation

InTheCloudDan
Copy link
Contributor

List of updates are included in CHANGELOG. This version is a significant rewrite of v4 except for how around data with the FlagStore is handled.

Copy link
Contributor

@ldhenry ldhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new features and ctx refactor looks good from my understanding. Most of my review is focussed on cleaning up commented out code. It might be worth pulling that out into a separate branch if we are planning to keep some of that around.

.prettierignore Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
import { registerCommand } from '../utils';

export function checkCodeRefs(ctx: ExtensionContext) {
const disposable = registerCommand('extension.checkLaunchDarkly', async () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth using consts for the command IDs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldhenry That's a great idea. It might take a bit of effort for cleaning up. Would it work if I did that as a patch release in the future?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup that works for me.

src/utils/contextYAML.ts Outdated Show resolved Hide resolved
src/utils/rulesYaml.ts Outdated Show resolved Hide resolved
test/flagLens.test.ts Outdated Show resolved Hide resolved
media/configuresettings.md Outdated Show resolved Hide resolved
Dan O'Brien and others added 9 commits February 6, 2024 08:14
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
Co-authored-by: Henry Barrow <[email protected]>
@InTheCloudDan InTheCloudDan requested a review from ldhenry February 6, 2024 13:29
Copy link
Contributor

@ldhenry ldhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@InTheCloudDan InTheCloudDan merged commit 92a7aef into main Feb 6, 2024
2 checks passed
@InTheCloudDan InTheCloudDan deleted the dob/flagActions branch February 6, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants