Move commands to constants and clean up circular imports #116

InTheCloudDan · 2024-02-08T14:09:19Z

Move all existing command strings to commands.ts
Move some existing strings used in multiple places to constants.ts
Create interfaces for existing classes to clean up circular import references. There's still a few left but this PR is large enough as is.
Remove some more commented out code.

This PR when merged should fail the deploy step. We are not incrementing the version here, just making future building easier.

move commands to consts

remove commented code

cleanup more unused code

ldhenry

Seems like a solid refactor to me.

src/commands/configureLaunchDarklyEnvironment.ts

src/models.ts

Co-authored-by: Henry Barrow <[email protected]>

Daniel OBrien added 3 commits February 8, 2024 07:27

add interfaces to fix circular import

9a1983d

move commands to consts

replace more string parts with consts

f2af40e

remove commented code

remove OAuth strings

d69bff7

cleanup more unused code

InTheCloudDan requested a review from ldhenry February 8, 2024 14:09

ldhenry approved these changes Feb 8, 2024

View reviewed changes

src/commands/configureLaunchDarklyEnvironment.ts Outdated Show resolved Hide resolved

src/models.ts Show resolved Hide resolved

Dan O'Brien and others added 2 commits February 8, 2024 09:25

Update src/commands/configureLaunchDarklyEnvironment.ts

7e6616c

Co-authored-by: Henry Barrow <[email protected]>

update string to const

0fa575e

InTheCloudDan merged commit ff565d0 into main Feb 8, 2024
2 checks passed

InTheCloudDan deleted the dob/Consts branch February 8, 2024 14:34

Provide feedback