feat: Implement backup and restore of dev-server database #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmashuda
changed the title
dmashuda
commented
Feb 6, 2025
| @@ -35,7 +40,7 @@ func (s Sqlite) GetDevProjectKeys(ctx context.Context) ([]string, error) { | |||
| return keys, nil | |||
| } | |||
|
|
|||
| func (s Sqlite) GetDevProject(ctx context.Context, key string) (*model.Project, error) { | |||
| func (s *Sqlite) GetDevProject(ctx context.Context, key string) (*model.Project, error) { | |||
There was a problem hiding this comment.
converted to pointer so that s.database can be updated after db restore
dmashuda
commented
Feb 6, 2025
| if err != nil { | ||
| return "", errors.Wrap(err, "unable to close database before restoring backup") | ||
| } | ||
| err = os.Rename(filepath, s.dbPath) |
dmashuda
changed the title
tvarney13
approved these changes
Feb 6, 2025
mike-zorn
reviewed
Feb 6, 2025
| conns []*sqllite.SQLiteConn | ||
| } | ||
|
|
||
| func NewManager(dbPath string, dbName string, backupFilePattern string, restoreFilePattern string) *Manager { |
There was a problem hiding this comment.
I think we need a comment here to indicate the expected lifecycle of the managers. It looks like each one gets its own unique file name space so you could run multiple managers at the same time, but you also need to use care to not reuse the same one?
There was a problem hiding this comment.
Done:
- The manager is safe to create multiple instances
- Each instance can only run 1 backup/restore at a time
mike-zorn
reviewed
Feb 6, 2025
mike-zorn
reviewed
Feb 6, 2025
mike-zorn
reviewed
Feb 6, 2025
Co-authored-by: Mike Zorn <[email protected]>
Co-authored-by: Mike Zorn <[email protected]>
mike-zorn
reviewed
Feb 6, 2025
| return "", errors.Wrap(err, "open backup database") | ||
| } | ||
|
|
||
| defer func(sourceDb *sql.DB) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Allows for exporting a backup and restoring a backup of the underlying sqlite3 database.
Downloading a backup db
Restoring a backup db
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
Provide a clear and concise description of what you expect to happen.
Describe alternatives you've considered
Provide a clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context about the pull request here.