Skip to content

Commit

Permalink
fix: Limit triomphe dependency to <=0.1.10 (#83)
Browse files Browse the repository at this point in the history
Our SDK uses `moka` for some unit tests, which in turn has a dependency
on `triomphe`. `triomphe` does not provide an MSRV, resulting in their
latest release breaking on rustc 1.74.

To avoid bumping our own MSRV to 1.76 for now, we are going to force the
`triomphe` dependency to be <=0.1.10. Once we bump rustc in the future,
we can clean up this change.
  • Loading branch information
keelerm84 authored May 31, 2024
1 parent 45e3451 commit 5a52e41
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions launchdarkly-server-sdk/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ description = "LaunchDarkly Server-Side SDK"
version = "2.1.0"
authors = ["LaunchDarkly"]
edition = "2021"
# TODO: When you change this to 1.76+, remove the explicit triomphe dependency
# below.
rust-version = "1.74.0" # MSRV
license = "Apache-2.0"
homepage = "https://docs.launchdarkly.com/sdk/server-side/rust"
Expand Down Expand Up @@ -31,6 +33,10 @@ tokio = { version = "1.17.0", features = ["rt-multi-thread"] }
parking_lot = "0.12.0"
tokio-stream = { version = "0.1.8", features = ["sync"] }
moka = { version = "0.12.1", features = ["sync"] }
# NOTE: This dependency is only here to deal with a rustc compliation issue.
# Once we move to rustc 1.76, we should be able to remove this explicit
# dependency.
triomphe = { version = "<=0.1.10" }
uuid = {version = "1.2.2", features = ["v4"] }
hyper = { version = "0.14.19", features = ["client", "http1", "http2", "tcp"] }
hyper-rustls = { version = "0.24.1" , optional = true}
Expand Down

0 comments on commit 5a52e41

Please sign in to comment.