feat: add role attributes to custom roles #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-5765/add-role-attributes-to-custom-roles
sloloris
changed the base branch from
main
to
imiller/REL-5765/upgrade-ldapi-client
sloloris
commented
Feb 6, 2025
| }) | ||
| } | ||
|
|
||
| func TestAccCustomRole_CreateWithNotStatements(t *testing.T) { |
There was a problem hiding this comment.
i consolidated all the custom roles tests. since the update tests all had a create step using the same resource configs anyways, it was redundant to have separate create and update tests.
Base automatically changed from
imiller/REL-5765/upgrade-ldapi-client
to
main
February 6, 2025 10:42
ldhenry
approved these changes
Feb 6, 2025
sloloris
deleted the
imiller/REL-5765/add-role-attributes-to-custom-roles
branch
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tests and documentation.