-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add auto apply to env approvals #295
base: main
Are you sure you want to change the base?
feat: add auto apply to env approvals #295
Conversation
It looks like we're going to need to hook up ServiceNow in our acceptance test account. I can do this now. |
This is done now. I re-ran the tests but it's still failing because a template is not being specified. Also, you are likely to run into the error reported in #223 until the fix in REL-5726 is merged. |
thank you!!! this is fixed, but we're now hitting the previously identified bug with the segment approvals config - i think possibly it may have been fixed for post creates but overlooked for patches. i am putting this back into draft mode while we address that first. |
Hmmm. The fix I did was for PATCH environment. Sounds like maybe it didn't work. I can dig into this |
@blaqbern, I just re-ran the tests and the error is:
This is slightly different than what it said previously:
I think that means we need to make a similar change for the |
Wait!
Testing
For any changes you make, please ensure your acceptance test conform to the following:
ImportState
andImportStateVerify
are set to true.ImportStateVerifyIgnore
can be used if we explicitly expect a value to be different when imported, such as in the case of obfuscated values like API keysLaunchDarkly Employees
For more information on how to build, test, and release, see the internal README on Confluence.