Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto apply to env approvals #295

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sloloris
Copy link
Member

Wait!

  • Have you added comprehensive tests?
  • Have you updated relevant data sources as well as resources?
  • Have you updated the docs?

Testing

For any changes you make, please ensure your acceptance test conform to the following:

  • every single new attribute is tested
  • optional attributes revert to null or default values if removed
  • attributes that interact interact as expected
  • block values behave as expected when reordered
  • nested fields on maps or list/set items function as expected. Terraform does not actually enforce most schema attributes on nested items
  • each test step for a configuration is followed by a test step where ImportState and ImportStateVerify are set to true. ImportStateVerifyIgnore can be used if we explicitly expect a value to be different when imported, such as in the case of obfuscated values like API keys

LaunchDarkly Employees

For more information on how to build, test, and release, see the internal README on Confluence.

@sloloris sloloris marked this pull request as ready for review February 14, 2025 18:09
@sloloris sloloris requested review from a team as code owners February 14, 2025 18:09
@ldhenry
Copy link
Collaborator

ldhenry commented Feb 14, 2025

It looks like we're going to need to hook up ServiceNow in our acceptance test account. I can do this now.

@ldhenry
Copy link
Collaborator

ldhenry commented Feb 14, 2025

It looks like we're going to need to hook up ServiceNow in our acceptance test account. I can do this now.

This is done now. I re-ran the tests but it's still failing because a template is not being specified. Also, you are likely to run into the error reported in #223 until the fix in REL-5726 is merged.

@sloloris
Copy link
Member Author

sloloris commented Feb 14, 2025

It looks like we're going to need to hook up ServiceNow in our acceptance test account. I can do this now.

thank you!!! this is fixed, but we're now hitting the previously identified bug with the segment approvals config - i think possibly it may have been fixed for post creates but overlooked for patches. i am putting this back into draft mode while we address that first.

@sloloris sloloris marked this pull request as draft February 14, 2025 19:04
@blaqbern
Copy link

It looks like we're going to need to hook up ServiceNow in our acceptance test account. I can do this now.

thank you!!! this is fixed, but we're now hitting the previously identified bug with the segment approvals config - i think possibly it may have been fixed for post creates but overlooked for patches. i am putting this back into draft mode while we address that first.

Hmmm. The fix I did was for PATCH environment. Sounds like maybe it didn't work. I can dig into this

@ldhenry
Copy link
Collaborator

ldhenry commented Feb 18, 2025

It looks like we're going to need to hook up ServiceNow in our acceptance test account. I can do this now.

thank you!!! this is fixed, but we're now hitting the previously identified bug with the segment approvals config - i think possibly it may have been fixed for post creates but overlooked for patches. i am putting this back into draft mode while we address that first.

Hmmm. The fix I did was for PATCH environment. Sounds like maybe it didn't work. I can dig into this

@blaqbern, I just re-ran the tests and the error is:

{"message":"The `serviceKind` and `serviceConfig` fields for `approvalSettings` and `resourceApprovalSettings` must match"}

This is slightly different than what it said previously:

{"message":"approvalSettings and resourceApprovalSettings service properties must match"}

I think that means we need to make a similar change for the serviceConfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants